Re: [Fire-commits] fire/irc ircService.m,1.60,1.61

Except it doesn't work!

It handles it on the display side just fine, but try running another 
client in the irc chatroom.  You will see "/me blah" instead of an 
action.  I regularly test using the linux irc command line client on my 
own irc server to test the conversation branch.

MIS_SERVICE_CALLOUT is in Shared states, and is after MIS_SERVICE_SEND. 
  The /me detection needs to be done before send, or it is not very 
useful.

------------------------------------------------------------------
Graham Booker                   Texas A&M University
[email protected]    Graduate Student in ELEN
------------------------------------------------------------------
On Mar 29, 2004, at 11:28 PM, Alan Humpherys wrote:

> There is already code to detect and handle /me actions in MessageItem  
> (the IRC service callout)
>
> Did that stop working!
> Alan
> On Mar 29, 2004, at 8:55 PM, [email protected] wrote:
>
>> Update of /cvsroot/fire/fire/irc
>> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv30336
>>
>> Modified Files:
>> 	ircService.m
>> Log Message:
>> Simple fix to make actions work properly on IRC.  The things you 
>> discover when you use the irc service to test display of things 
>> (since I can run my own irc server that I can cycle if I log into it 
>> too often).
>>
>>
>>
>> Index: ircService.m
>> ===================================================================
>> RCS file: /cvsroot/fire/fire/irc/ircService.m,v
>> retrieving revision 1.60
>> retrieving revision 1.61
>> diff -C2 -d -r1.60 -r1.61
>> *** ircService.m	14 Mar 2004 11:53:00 -0000	1.60
>> --- ircService.m	30 Mar 2004 03:55:31 -0000	1.61
>> ***************
>> *** 208,212 ****
>>   - (NSString *)encodeMessageAttributes:(MessageItem *)msg
>>   {
>> !     return [[msg attributedMessage] getIRCHTML];
>>   }
>>
>> --- 208,218 ----
>>   - (NSString *)encodeMessageAttributes:(MessageItem *)msg
>>   {
>> !     NSMutableAttributedString *attributedMessage = [msg 
>> attributedMessage];
>> !
>> !     if([[attributedMessage string] hasPrefix:@"/me "]){
>> !         [msg setMessageType:MI_ACTION_MESSAGE];
>> !         [attributedMessage deleteCharactersInRange:NSMakeRange(0, 
>> 4)];
>> !     }
>> !     return [attributedMessage getIRCHTML];
>>   }
>>
>>
>>
>>
>> -------------------------------------------------------
>> This SF.Net email is sponsored by: IBM Linux Tutorials
>> Free Linux tutorial presented by Daniel Robbins, President and CEO of
>> GenToo technologies. Learn everything from fundamentals to system
>> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>> _______________________________________________
>> Fire-commits mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/fire-commits
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: IBM Linux Tutorials
> Free Linux tutorial presented by Daniel Robbins, President and CEO of
> GenToo technologies. Learn everything from fundamentals to system
> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
> _______________________________________________
> fire-development mailing list
> fire-development-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/fire-development
>