Re: [Fire-commits] fire ClassicDisplayView.m,1.10,1.11 MessageItem.m,1.61,1.62

Graham,

Why the change to not strip the font and color attributes from Service 
messages?  The original idea was that Service messages are shown in 
their own particular color and font. (That would distinguish them from 
other messages)

Service messages are the "xxx has logged off" or "failed to decrypt 
message" types.

Alan
------
Alan Humpherys
Fire Development Team
http://fire.sf.net

On Mar 2, 2005, at 2:46 PM, [email protected] wrote:

> Update of /cvsroot/fire/fire
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv1335
>
> Modified Files:
> 	ClassicDisplayView.m MessageItem.m
> Log Message:
> Fixes http://fire.sourceforge.net/forums/viewtopic.php?p=3259 for ToT
>
>
> Index: ClassicDisplayView.m
> ===================================================================
> RCS file: /cvsroot/fire/fire/ClassicDisplayView.m,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -C2 -d -r1.10 -r1.11
> *** ClassicDisplayView.m	12 Jan 2005 23:54:59 -0000	1.10
> --- ClassicDisplayView.m	2 Mar 2005 21:46:43 -0000	1.11
> ***************
> *** 433,436 ****
> --- 433,442 ----
>           messageNode = messageNode->next;
>       }
> +     [ret removeAttribute:NSFontAttributeName 
> range:NSMakeRange(0,[ret length])];
> +     [ret addAttribute:NSFontAttributeName value:[[NSApp delegate] 
> incomingMessageFont] range:NSMakeRange(0,[ret length])];
> +     [ret removeAttribute:NSForegroundColorAttributeName 
> range:NSMakeRange(0,[ret length])];
> +     [ret addAttribute:NSForegroundColorAttributeName 
> value:[[ThemeController sharedInstance] colorForKey:ACTION_COLOR] 
> range:NSMakeRange(0,[ret length])];
> +     [ret removeAttribute:NSBackgroundColorAttributeName 
> range:NSMakeRange(0,[ret length])];
> +     [ret addAttribute:NSBackgroundColorAttributeName 
> value:[[ThemeController sharedInstance] colorForKey:BACKGROUND_COLOR] 
> range:NSMakeRange(0,[ret length])];
>       return ret;
>   }
>
> Index: MessageItem.m
> ===================================================================
> RCS file: /cvsroot/fire/fire/MessageItem.m,v
> retrieving revision 1.61
> retrieving revision 1.62
> diff -C2 -d -r1.61 -r1.62
> *** MessageItem.m	18 Feb 2005 03:06:38 -0000	1.61
> --- MessageItem.m	2 Mar 2005 21:46:43 -0000	1.62
> ***************
> *** 804,809 ****
>
>               case MIS_OVERRIDE_FONTS_COLORS:
> !                 if (((!outbound) && ([defaults 
> boolForKey:DISABLE_INCOMING_FONTS])) ||
> !                     (messageType == MI_SERVICE_MESSAGE)) {
>   					
>   					[attributedString removeAttribute:NSFontAttributeName
> --- 804,808 ----
>
>               case MIS_OVERRIDE_FONTS_COLORS:
> !                 if ((!outbound) && ([defaults 
> boolForKey:DISABLE_INCOMING_FONTS])) {
>   					
>   					[attributedString removeAttribute:NSFontAttributeName
> ***************
> *** 814,819 ****
>                   }
>
> !                 if (((!outbound) && ([defaults 
> boolForKey:OVERRIDE_INCOMING_COLORS])) ||
> !                     (messageType == MI_SERVICE_MESSAGE)) {
>
>                       NSColor* tmpColor;
> --- 813,817 ----
>                   }
>
> !                 if ((!outbound) && ([defaults 
> boolForKey:OVERRIDE_INCOMING_COLORS])) {
>
>                       NSColor* tmpColor;
>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real 
> users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Fire-commits mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/fire-commits



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click