Re: MessageAuthCodeTest fails with the latest version of bcprov-jdk15on

Florent Daigniere <[email protected]> Sat, 25 Feb 2017 11:00:16 +0100

Newsgroups	gmane.network.freenet.devel
Message-ID	<[email protected]>

On Fri, 2017-02-24 at 15:56 +0200, Rostislav Krasny wrote:
> Hi,
> 
> I made a local Maven fork of the Freenet Fred project.


Good luck with that. The plan is to use gradle going forward (have a
look to what's on the branch called "next").


>  One of my maven
> dependencies is:
> 
>         <dependency>
>             <groupId>org.bouncycastle</groupId>
>             <artifactId>bcprov-jdk15on</artifactId>
>             <version>1.56</version>
>         </dependency>
> 
> With this bcprov-jdk15on version most of the tests in the
> MessageAuthCodeTest class fail because of
> IllegalArgumentException("Invalid format for r portion of Poly1305
> key."). The reason is some bug fix in the bcprov-jdk15on itself,
> related to "compliance with RFC7539". Take a look at their bug fix
> commit:
> 
> https://github.com/bcgit/bc-java/commit/9d0edfbede2bc877257fdf704b8373
> 15de2708ec
> 
> They changed the Poly1305 key bit numbers they check in the
> Poly1305KeyGenerator class.
> 
> If I continue to use the fixed bcprov-jdk15on version will it have any
> negative impact to the Freenet functionality or only to the
> MessageAuthCodeTest tests?


We are currently not using Poly1305 anywhere.

>  Will you upgrade your bcprov-jdk15on to the
> latest version?
> 

Eventually, yes.

Florent

_______________________________________________
Devl mailing list
[email protected]
https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl

signature.asc (application/pgp-signature, 488 B)