Re: Open Selected Key / Attachment in Browser
bbackde-gM/[email protected] Wed, 7 Apr 2010 20:59:31 +0200
| Newsgroups | gmane.network.freenet.frost.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Artur, thanks for your patch. I have some points about it. In MiscPanel, line 262 and following you forgot the 'w' in the variable name. In MessageTextPane, the context menu items for the optional 'show in browser' functionality is always shown, no matter if the setting is enabled or not. After all I don't get the point what the setting is about at all ? Is it the needed prefix to show content delivered by the freenet node? Now the most important (and sad) point: the Desktop class you use to invoke the system default browser is not available in JDK 1.5. Currently Frost runs on 1.5 only. This was needed to support Frost on all important OSes, e.g. MacOS. If someone could tell us that we have a 1.6 on all OSses now, maybe we could start to require it. But consider that such a requirement update needs some good reason to explain it to the users. On Wed, Apr 7, 2010 at 16:04, artur <[email protected]> wrote: > Hi, > > here is another small patch. > It allows to open a link or attachment in the system default browser. > This only works when the URL prefix under the options/misc menu is > configured. If this option is empty, no URL will be opened (for safety / > information leak). > > Cheers > > artur > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Jtcfrost-devl mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/jtcfrost-devl > > -- __________________________________________________ GnuPG key: (0x48DBFA8A) Keyserver: pgpkeys.pca.dfn.de Fingerprint: 477D F057 1BD4 1AE7 8A54 8679 6690 E2EC 48DB FA8A __________________________________________________ ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev