Re: Node gets more FEC blocks than needed

* Matthew Toseland <toad-EI5O+8PHWbJeeLb3ft/[email protected]> [2007-01-15 18:04:23]:

> On Sat, Jan 06, 2007 at 12:56:13PM +0100, Florent Daignière (NextGen$) wrote:
> > * Milan Holzäpfel <[email protected]> [2007-01-06 08:56:46]:
> > 
> > > On Thu, 4 Jan 2007 16:03:22 +0100
> > > Florent Daignière (NextGen$) <[email protected]> wrote:
> > > 
> > > > * bbackde-gM/[email protected] <bbackde-gM/[email protected]> [2007-01-04
> > > > 15:48:09]:
> > > >
> > > > > [...]
> > > > >
> > > > > But the current behavior often leads to downloads that have more
> > > > > than 100% progress *g*
> > > >
> > > > Is it *that* important to have an accurate progress bar ? some blocks
> > > > can take *ages* to be retrived whereas some will come up
> > > > instantaneously... Imho we can't provide a reliable
> > > > percentage/ETA/whatever for small files even if we had detailled stats
> > > > on what's going on.
> > > 
> > > That's probably very true, but I always wonder whether > 100% means
> > > that there is a bug in fproxy / freenet and it will never finish
> > > because it didn't notice that it was finished already or something.
> > 
> > It's not a bug.
> > 
> > > It's probably a bad idea to say that the download is > 100%, from a
> > > user point of view.
> > 
> > Well, it won't say such a thing if you aren't running the
> > "AdvancedDarknetMode" :)
> > 
> > See how it's implemented on
> > http://emu.freenetproject.org/cgi-bin/viewcvs.cgi/trunk/freenet/src/freenet/clients/http/QueueToadlet.java?rev=11427&view=markup
> > 
> > look for "private HTMLNode createProgressCell(" ...
> > 
> > Depending on if advanced mode is on or off, we consider that the total
> > amount of blocks is either the "required" or the "total number of
> > inserted blocks".
> > 
> > Both approaches do have problems :
> >  in non advanced mode, a download can finish at 2/3
> >  in avanced mode a download can finish (worst case assuming it finishes) at 3/2 !
> 
> That's bizarre. I don't see why we shouldn't use # required in both
> cases. Having said that we may want to put some logic in to not count
> blocks which are unnecessary (within a given segment) towards the
> overall total?

I don't regard that as an important matter. I suggest you fill in a
ticket on mantis under the category wishlist ;)

NextGen$

_______________________________________________
Tech mailing list
[email protected]
http://emu.freenetproject.org/cgi-bin/mailman/listinfo/tech

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFFq8MDU/Z/dHFfxtcRAsk7AJ4okfshXBtnt9a5LibusjYsHE+xKgCeJnTP
uyNmptafIy7G/x6NI32s8K0=
=ZA1B
-----END PGP SIGNATURE-----