Re: Re: query about testing/packaging/basic-install-01/testparams.sh change

-----BEGIN PGP SIGNED MESSAGE-----


| From: Michael Richardson <[email protected]>
| To: D. Hugh Redelmeier <[email protected]>
| Cc: FreeS/WAN Design <[email protected]>
| Subject: [Design] Re: query about
|     testing/packaging/basic-install-01/testparams.sh change
| 
| -----BEGIN PGP SIGNED MESSAGE-----
| 
| 
| >>>>> "D" == D Hugh Redelmeier <[email protected]> writes:
|     D> I doubt that this was ever tested: the variable intended was surely
|     D> 	USE_LWRES, not USE_LWDNSQ
|     D> MCR: I'll leave you to fix this and test it.
| 
|     D> Perhaps we need installation tests for each case.  I realise that this
|     D> is more work.
| 
|   Starting after the release of 2.00-rc1, we will switch this on in the HEAD,
| okay?

Your reply suggests you didn't understand what I was saying.
And you haven't fixed the (presumed) bug.

In testing/packaging/basic-install-01/testparams.sh, there is an
assignment:
	USE_LWDNSQ=true export USE_LWDNSQ
I suspect that you meant
	USE_LWRES=true export USE_LWRES
If you did, you should fix it.  And test the fix.

I'm guessing that your reply is a proposal to define USE_LWRES in
Makefile.inc so that this becomes the normal configuration.
I think that this is a mistake until lwdnsq can handle multiple
queries concurrently.

Hugh Redelmeier
[email protected]  voice: +1 416 482-8253

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: noconv

iQCVAwUBPj7wZ8FAuQPManGZAQHWdQP+J6NnnXW72o02GsGNujorAeGg6AlVzIEk
Hip5NYPkcc+dxemGRBt+Yg/9x1HMjT+BjQDVnYbyFec3uHDgI+Ieg78/iOqQdBtD
Jvmp4NwEggOeoOcyHF/sX3fPiXu0PFFXNgSJLYJFLq/ivh6nyeXCPCM6n5a9Zumb
rGR+IQKKGWQ=
=Mt2g
-----END PGP SIGNATURE-----