%hold for 0.0.0.0/0 observed

-----BEGIN PGP SIGNED MESSAGE-----


MCR:

You observed a too broad %hold on your system with the latest Pluto.  I 
don't know how that could be happening.  Could you add the following 
assertions to pluto and try to provoke it?

Thanks,

Hugh Redelmeier
[email protected]  voice: +1 416 482-8253

Note: I've added X to the start of each line to protect it from PGP.

XIndex: connections.c
X===================================================================
XRCS file: /freeswan/MASTER/freeswan/programs/pluto/connections.c,v
Xretrieving revision 1.153
Xdiff -u -r1.153 connections.c
X--- connections.c	7 Feb 2003 04:25:35 -0000	1.153
X+++ connections.c	8 Feb 2003 16:03:44 -0000
X@@ -1421,6 +1421,7 @@
X 
X 	/* If we are to proceed asynchronously, whackfd will be NULL_FD. */
X 
X+	passert(LHAS(LELEM(CK_PERMANENT) | LELEM(CK_INSTANCE), c->kind));
X #ifdef KLIPS
X 	if (held)
X 	{
X@@ -1515,6 +1516,7 @@
X 	else
X 	{
X 	    /* If we are to proceed asynchronously, whackfd will be NULL_FD. */
X+	    passert(CK_INSTANCE == c->kind);
X 	    passert(c->gw_info != NULL);
X 	    passert(HAS_IPSEC_POLICY(c->policy));
X 	    passert(LHAS(LELEM(RT_UNROUTED) | LELEM(RT_ROUTED_PROSPECTIVE), c->routing));
XIndex: kernel.c
X===================================================================
XRCS file: /freeswan/MASTER/freeswan/programs/pluto/kernel.c,v
Xretrieving revision 1.164
Xdiff -u -r1.164 kernel.c
X--- kernel.c	7 Feb 2003 04:25:35 -0000	1.164
X+++ kernel.c	8 Feb 2003 16:03:44 -0000
X@@ -1357,6 +1357,8 @@
X 		, opname, mybuf, peerbuf, text_said);
X 	});
X 
X+    passert(op == ERO_DELETE
X+	|| !(proto == SA_INT && spi == htonl(SPI_HOLD) && isanyaddr(&dflow_ska)));
X     return pfkey_msg_start(op & ERO_MASK, satype
X 	, "pfkey_msg_hdr flow", text_said, extensions)
X 
X@@ -1478,6 +1480,7 @@
X     enum routing_t ro = c->routing	/* routing, old */
X 	, rn = ro;	/* routing, new */
X 
X+    passert(LHAS(LELEM(CK_PERMANENT) | LELEM(CK_INSTANCE), c->kind));
X     /* figure out what routing should become */
X     switch (ro)
X     {
================ end ================

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3ia
Charset: noconv

iQCVAwUBPkUtCsFAuQPManGZAQG8GgQAs8/xMV1sLsWgIrEQszGgJA/0BOQlT+Uo
7gW32AR4B8NvWKklFferLdMxB/hWCshNPDN5ak2I4qcgb2xaWFHCxvEMl1xeKu/x
tdvxMuGX6qMD9JIzqyFmc4niAju8dPdMyu09WUEZ6qcD0f5l4abn6PWVxAncVurI
G+2Uaa0szxo=
=NjHV
-----END PGP SIGNATURE-----