Re: Revised notify_delete-2.00.diff, was Re: delete-sa-01 test
Michael Richardson <[email protected]>
| Newsgroups | gmane.network.freeswan.devel |
|---|---|
| Message-ID | <[email protected]> |
-----BEGIN PGP SIGNED MESSAGE----- The patch that was submitted appears to contain both processing of delete messages, and sending notifications of failures. I did not look as closely as Hugh did to the patch. These are two entirely seperate things, and need to be seperately tested. We have a test case for processing of delete messages. We do not have a test case for each of the 28 calls to SEND_NOTIFICATION. Some of the situations may be quite simple to do - just build a malformed phase 1 packet and feed it into pluto. Some will be rather complicated, as we'll have to build a phase 1, and then insert malformed packets into the phase 2, *properly encrypted*. This is much more difficult to do. We are looking for help here. ] ON HUMILITY: to err is human. To moo, bovine. | firewalls [ ] Michael Richardson, Sandelman Software Works, Ottawa, ON |net architect[ ] [email protected] http://www.sandelman.ottawa.on.ca/ |device driver[ ] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) Comment: Finger me for keys iQCVAwUBPkmgxYqHRg3pndX9AQGbiQQAk3wyfJdKQeqvIxiEVSwo0otqxEA0s8hu PpiOEV2EyC9hg0tqMuiIvBUpM1SF07k0CNq50wpYlXuBZTaZuNpEs+fpqTxZ0Zt2 ZZ74xZq+tJjLfPcUG66dsR/O2C4JFY2eNZ1Kj2lKmx/2FN7aZ79vtVb4wAH+0eNI F7mkKhrtzbU= =WtUN -----END PGP SIGNATURE-----