Re: GNUNET_NAMESTORE_records_lookup non-void return

Martin Schanzenbach <[email protected]>
Newsgroups gmane.network.gnunet.devel
Message-ID <1664192971-sup-6980@werkbank>
Thank you.
I wonder why the default buildconfig does not throw warnings in this
case...

Fixed

Excerpts from Andreas Stieger's message of 2022-09-26 13:32:58 +0200:
> Hello,
> 
> from 0.17.6 build:
> 
> [  140s] namestore_api.c: In function 'GNUNET_NAMESTORE_records_lookup':
> [  140s] namestore_api.c:1221:1: error: control reaches end of non-void function [-Werror=return-type]
> [  140s]  1221 | }
> [  140s]       | ^
> [  140s] cc1: some warnings being treated as errors
> [  140s] make[3]: *** [Makefile:2323: namestore_api.lo] Error 1
> 
> From https://git.gnunet.org/gnunet.git/commit/src/namestore/namestore_api.c?id=7678d77b1cb0dcfd8887016d35b27fbedb136050
> 
> +struct GNUNET_NAMESTORE_QueueEntry *
> +GNUNET_NAMESTORE_records_lookup (
> [...]
> +{
> +  records_lookup (h, pkey, label,
> +                  error_cb, error_cb_cls,
> +                  rm, rm_cls, GNUNET_NO);
> +
> +}
> 
> Obvious return missing.
> 
> Andreas
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEPREGPBD5jRS9JNFHCwmY74b1m2oFAmMxkegACgkQCwmY74b1
m2oB6Q/+My81hVN2IHOyerM4VlMZEpmAvxCnPeLg754Y+BD021hAlgLL+pDLDKAm
Yfieo8Sz4brcaBf2NdSV2G3FP3VVqYZ0A//Lu89rg7IEps9gjUs73TEgm7CA+v5E
UOKVoRqP5htc930UjTe9hNxwt9SrVYwIfvY8LzakT49xSJDF4HmDjokw09To1UGq
F+u4WMWrOZtSU6twc4UTdDltGOjPxfbZ/nApwMjQGSJJ6nWJo3pYTl7Jt6WZNjFZ
KixWljw/v8jwIOrR49dtFglo7YdXKEEz3hM1XS+T1ZrtSut4nqI/Fh1w9mSGueLY
1bkjIpwySkj1dD5qVQmpciRQTgsc9J+Hh3QQQqOanFZjTRYN1b2AEW+w4TCSnkXw
rDT0aGto1ElkDCYD9c1CZLbjjWRt9RvO8966bUyLAHG4Qc8G1YkmOUQnYhqgpr0v
Ve7hiXuydd/zrCqtbkkt300tkUjgH0vYDHFCQqBqKpoLwHXhroWFh/HPugz2JVOZ
Zw2HYvOZZgaurvgG+K+pRmDNafGg3RPfRVAn1lL8iCt1SfPj6pMQfCv2SuEldk1p
B11OMyXw4KKrddCp9d1W1D7DnLy56lTmHpAvyNgjVOKMQr26Mg0M05ZWvi4kRnmJ
/VM1EeLxgAy3eY6vX6rrBVdlX+AbGpXbRcIT3ZiIuEG8NQJDl0s=
=Gu5p
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.