Re: [PATCH] Fix git detection when cloned as submodule
Christian Grothoff <[email protected]> Mon, 9 Jan 2023 22:41:00 +0100
| Newsgroups | gmane.network.gnunet.devel |
|---|---|
| Message-ID | <[email protected]> |
Thanks, patch applied to Git. -Christian On 1/9/23 21:00, Dan Church wrote: > Hi GNUNet devs! > > I found an issue where VERSION and PACKAGE_VERSION would always be set > to 'unknown' if gnunet was cloned as a git submodule. > > Steps to repro: > > mkdir superproject > cd superproject > git init > git submodule addhttps://git.gnunet.org/gnunet.git > cd gnunet > contrib/get_version.sh > > At this point, 'unknown' will print if this is still an issue. > > With the attached fix, '0.19.2-6-gbe0ba43d7' will print. > >