Re: [PATCH] util: fix segfaults when config lacks a section

Martin Schanzenbach <[email protected]> Wed, 24 Jul 2024 16:44:22 +0000

Newsgroups	gmane.network.gnunet.devel
Message-ID	<[email protected]>

Thank you for the patch.

I think you just may be starting/using the services in a peculiar way
that triggers the configuration API to be called with NULL.

I applied the patch for now, but that does not mean this will run
smoothly (as in, cfg should likely never be NULL anyway with a proper
setup)

BR

On Wed, 2024-07-24 at 18:36 +0200, fence wrote:
> Hi!
> 
> I ran into gnunets services just segfaulting sometimes.
> 
> I ran into the behaviour when running the transport service with the
> transport.conf from the (meson) build output. (with an additional
> PEER 
> section for the private key).
> 
> I think I had similar segfaults with other services too, but don't
> feel 
> like trying to reproduce those tbh.
> 
> Was the NULL check missing due to performance or something?
> 
> Kind regards
> fence

signature.asc (application/pgp-signature, 862 B)