Request Review (testing/helper)
ch3 <[email protected]> Fri, 27 Sep 2024 14:34:58 +0200
| Newsgroups | gmane.network.gnunet.devel |
|---|---|
| Message-ID | <[email protected]> |
Hello,
could someone please have a look at my last commit?
https://git.gnunet.org/gnunet.git/commit/?id=0a0f332664271ea4d53a0276638a407e92b01483
Besides general sanity checks, I specifically am curious about:
1. Along the lines of the FIXME in helper.c: Is it intended behavior
that a helper gets shut down if it has an exception handler, but if
it doesn't it gets restarted?
2. Testing keeps a list of helpers in ns->helpers[]. When one of the
helpers' exception callbacks is called - would it be desirable to
take it out of the array, or is it fine to just mark it as finished?
Thanks in advance,
ch3
(unnamed)
(application/pgp-keys, 868 B) - not displayed
signature.asc
(application/pgp-signature, 228 B)
-----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRJThCE434IyPU5wMH6FaTWvxCd9QUCZvamaAAKCRD6FaTWvxCd 9WzdAQCMvTecPLoqQpEtwZuVhxRmzEuSkcIC/2edXYKy2x4eaQD/YhcWBWGqqC60 GY4S2lZ8h93FHUjtJRFqys/S2woKNAE= =XE1+ -----END PGP SIGNATURE-----