Re: [PATCH 8/8] namecache: build flat namecache plugin

Martin Schanzenbach <[email protected]> Fri, 10 Oct 2025 09:09:22 +0200
Newsgroups gmane.network.gnunet.devel
Message-ID <[email protected]>
Hello,

this was done on purpose because we want to deprecate/remove the flat
file/heap DB implementations as they are slow and buggy and hard to
maintain because not really used. I guess I forgot to delete the source
file.
Also, sqlite is pretty close already to a flat file implementation but
a lot faster than anything we will come up with.
What is the requirement to keep it from you?

BR
Martin

On Fri, 2025-10-10 at 02:14 +0100, Daniel Golle wrote:
> Build flat namecache plugin which was dropped with the transition to
> meson, leaving behind the sourcecode without a way to build it.
> ---
> =C2=A0src/plugin/namecache/meson.build | 10 ++++++++++
> =C2=A01 file changed, 10 insertions(+)
>=20
> diff --git a/src/plugin/namecache/meson.build
> b/src/plugin/namecache/meson.build
> index f1600fcc6..3dee0c761 100644
> --- a/src/plugin/namecache/meson.build
> +++ b/src/plugin/namecache/meson.build
> @@ -29,6 +29,16 @@ shared_module(
> =C2=A0=C2=A0=C2=A0=C2=A0 install_dir: get_option('libdir') / 'gnunet',
> =C2=A0)
> =C2=A0
> +shared_module(
> +=C2=A0=C2=A0=C2=A0 'gnunet_plugin_namecache_flat',
> +=C2=A0=C2=A0=C2=A0 ['plugin_namecache_flat.c'],
> +=C2=A0=C2=A0=C2=A0 install_rpath: rpath_option,
> +=C2=A0=C2=A0=C2=A0 dependencies: [libgnunetutil_dep, libgnunetgnsrecord_=
dep],
> +=C2=A0=C2=A0=C2=A0 include_directories: [incdir, configuration_inc],
> +=C2=A0=C2=A0=C2=A0 install: true,
> +=C2=A0=C2=A0=C2=A0 install_dir: get_option('libdir') / 'gnunet',
> +)
> +
> =C2=A0if pq_dep.found()
> =C2=A0=C2=A0=C2=A0=C2=A0 shared_module(
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'gnunet_plugin_namecache=
_postgres',