Re: [core-dev] current limewire issues

Sam Berlin <[email protected]> Fri, 6 Aug 2004 11:59:06 -0400
Newsgroups gmane.network.gnutella.limewire.core.devel
Message-ID <[email protected]>
Hi Eugene,

Thanks for the very good comments.  Replies are inline below...

> - Before, limewire says "Poor" about connection to one ultrapeer, and  
> "Excellent" about four. Now it connects to one and says "Excellent",  
> and says "Turbocharged" about two! And connects to three maximum. Bug?

This should not be the case.  Have you changed CommonUtils.isPro to  
always return true?  That would account for what you're seeing.

>
> - When I press "find sources" on file wich have some non-alphanumber  
> chars in filename (square brackets or percent sign) I got exception
> java.lang.IllegalArgumentException: illegal chars in query
> at  
> com.limegroup.gnutella.messages.QueryRequest.createMulticastQuery(Query 
> Request.java:780)
> at  
> com.limegroup.gnutella.MessageRouter.sendDynamicQuery(MessageRouter.jav 
> a:1331)
> at  
> com.limegroup.gnutella.DownloadManager.sendQuery(DownloadManager.java:9 
> 00)
> at  
> com.limegroup.gnutella.downloader.ManagedDownloader.sendRequery(Managed 
> Downloader.java:760)
> at  
> com.limegroup.gnutella.downloader.ManagedDownloader.completeDownload(Ma 
> nagedDownloader.java:738)
> at  
> com.limegroup.gnutella.downloader.ManagedDownloader.access$100(ManagedD 
> ownloader.java:53)
> at  
> com.limegroup.gnutella.downloader.ManagedDownloader$1.managedRun(Manage 
> dDownloader.java:677)
> at com.limegroup.gnutella.util.ManagedThread.run(ManagedThread.java:49)

Yes, this is a bug and will be fixed before the next release.  FYI, you  
can view bugs reported to us at http://bugs.limewire.com/bugs/home.jsp .

> - Now limewire use looks.jar. IIRC, it works only with java 1.4 or  
> higher. So, 1.3 support dropped?
> And I really prefer Metal-based lime l&f. Well, Looks from JGoodies  
> looks nice, but Metal better for eyes.

Looks will only be used on Java 1.4, however LimeWire will still run on  
1.3 (using only Metal).  The Looks L&F is really only an extension to  
Metal that corrects a few things -- it isn't a completely new L&F.  The  
main visible difference is that the buttons (ones without icons) no  
longer use custom images and instead are drawn by the L&F.

>
> - Here new option "show icon text", but no option "show only text"  
> (without icon), also I think "use regular button" option will be good.
> Buttons was nice. Why change this? ;)

A 'Use Regular Button' option is a good idea.  We'll add it.

Thanks,
  Sam

_______________________________________________
core-dev mailing list
[email protected]
http://www.limewire.org/mailman/listinfo/core-dev