Re: [codepatch] Re: [discuss] block all hosts

Hi Charles,

> Is there anything I could do to move along merging in the work that 
> has already been done to block files?

If you'd like, you can incorporate the code that was on the branch for 
hashing files into your patch, and then we can merge the whole blocking 
shebang at once.

 > Here is the code... basically (current < total) never seems to 
evaluate to true.

The 'filtered' display will only be shown if you use the 'filter 
results' tab on the left of the search results.  The GUI doesn't keep 
track of results that the core has thrown away (because they were 
blocked).

> In a related issue, does LimeWire really want to report the total 
> number of all hosts (including alternates) in the tab title?  It seems 
> to me that it would make more sense to only show the number of unique 
> results, as that is a much more meaningful number for the end user.  I 
> could fix that pretty easily I think.  Would a patch for that be 
> accepted?

We used to display the unique results, but after 'filter results' were 
added, we changed to the number of sources.  Users like seeing high 
numbers. :)

Thanks,
  Sam

_______________________________________________
discuss mailing list
[email protected]
http://www.limewire.org/mailman/listinfo/discuss