Re: [discuss] [Really last] Why are quoted searches so hard toimplement?
Sam Berlin <[email protected]> Mon, 23 May 2005 12:14:19 -0400
| Newsgroups | gmane.network.gnutella.limewire.general |
|---|---|
| Message-ID | <[email protected]> |
Take a look at: http://limewire.org/fisheye/viewrep/limecvs/core/com/limegroup/ gnutella/messages/QueryRequest.java?r=1.76#l1083 . It's really there to hurt automatons. Thanks, Sam On May 23, 2005, at 12:02 PM, Gregorio Roper wrote: > I'm pretty sure that LimeWire does not drop any queries based on > SearchSettings.BAD_CHARS, at least I cannot find any reference to it > in the LimeWire core. Some of the query filters are already of > questionable usefulness, but dropping queries that contain question > marks or slashes is completely unnecessary. > > PATRICIA looks really good, I can't wait to see it in action. > > mfg > gregorio > > Sam Berlin schrieb: >> I think the ultimate solution will have the server-side start parsing >> queries that contain quotes, as well as the GGEP extension of quotes. >> For a while we'll send out queries with the quotes stripped out & >> placed into the GGEP portion, so that _some_ results are still sent >> from older clients. Once a good amount has upgraded, we can shut off >> including quotes in GGEP and just place them into the search itself >> (this can be remotely signaled). We also can't use any delimiters >> that are also in SearchSettings.BAD_CHARS, because all LimeWires will >> drop those queries. >> Once the PATRICIA, Keywords, CharSequence, quotes phrase searching, >> etc... stuff is in, we should also look at merging the XML keywords >> into the main FileManager trie, so that normal searches can search >> against metadata phrases. The XML stuff should also use real keyword >> matching instead of String.startsWith. >> Thanks, >> Sam > > _______________________________________________ > discuss mailing list > [email protected] > http://www.limewire.org/mailman/listinfo/discuss > _______________________________________________ discuss mailing list [email protected] http://www.limewire.org/mailman/listinfo/discuss