Re: [gui-dev] layout patch

Hi Felix,

Thanks very much for sending this in.  The change looks very nice.  As 
a small detail, when adding components using a constraint, you can use 
the method:

   myContainer.add(myComponent, myConstraint);

That removes the need to cast the layout back to a GridBagLayout and 
removes the extra line of setConstraints.  GridBagConstraints are also 
cloned when they're added, so there's no need to create a new one prior 
to each component-adding.

Other than that, this looks very good!  It'll be added into CVS 
sometime later today.

In the future, you may want to use the codepatch at limewire.org 
mailing list for sending patches.  No big difference, but it helps us 
organize the messages a little better.

Thanks,
  Sam

On Feb 27, 2005, at 1:20 PM, Felix Berger wrote:

> Hi,
>
> while looking around how things are done in Limewire I did polished the
> ListEditor and the StandardListEditor.
>
> The changes for the StandardListEditor are:
>
> * use gridbag layout to make the (add, remove) buttons on the right 
> have the
> same horizontal size.
> * Removed button row implementation for this purpose, made
> ButtonRow.BUTTON_SEP public so the buttons still have the same 
> distance from
> each other
> * Use Actions internally
> * no interface changes
>
> The changes for ListEditor are:
>
> * use gridbag layout for nicer layout of the buttons, the insets can 
> still be
> tweaked
> * disable remove button when nothing is selected
> * enter key in editor field triggers add action
> * delete key in list triggers remove action
> * use actions internally
> * no public interface changes
>
> It's all in  one patch.
>
> Regards,
> Felix
>
> -- 
> Try Debian GNU/Linux!
> http://www.felix.beldesign.de/
> <layout.patch>_______________________________________________
> gui-dev mailing list
> [email protected]
> http://www.limewire.org/mailman/listinfo/gui-dev

_______________________________________________
gui-dev mailing list
[email protected]
http://www.limewire.org/mailman/listinfo/gui-dev