Re: [codepatch] Re: [gui-dev] "Ability to send download filename to search box"

Marcin Okraszewszki <[email protected]> Mon, 18 Jul 2005 09:18:54 +0200
Newsgroups gmane.network.gnutella.limewire.gui.devel
Message-ID <[email protected]>
This is a multi-part message in MIME format.
--------------070705060508060304050602
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-MIME-Autoconverted: from 8bit to quoted-printable by www.limewire.org id j6I7H73s019205

Here is an other attempt to do it with usage of SearchAction (there is
difference only in DownloadMediator, so I send a patch only for this).

Well, I don't know which is better. The advantage is that it uses the
same code to perform search - less maintenance if anything in search is
changed. On the other hand for me the solution is not that clear and
some preparing operations are done every time the menu is constructed,
not only in case an item was selected (eg. preparing the file name,
creating the original search information).

Well, judge it.

Regards,
Marcin Okraszewski

Marcin Okraszewski napisa=C5=82(a):
> Hi,
> I finally found some time to fit the patch into the new download pop up
> menu. It seems to work fine again. The attached patches contains groupe=
d
> changes per project.
>=20
> Best regards,
> Marcin Okraszewski
>=20


--------------070705060508060304050602
Content-Type: text/plain;
 name="DownloadMediator.java.patch2"
Content-Disposition: inline;
 filename="DownloadMediator.java.patch2"
Content-Transfer-Encoding: base64

SW5kZXg6IGNvbS9saW1lZ3JvdXAvZ251dGVsbGEvZ3VpL2Rvd25sb2FkL0Rvd25sb2FkTWVk
aWF0b3IuamF2YQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL2d1aS9jb20vbGltZWdy
b3VwL2dudXRlbGxhL2d1aS9kb3dubG9hZC9Eb3dubG9hZE1lZGlhdG9yLmphdmEsdgpyZXRy
aWV2aW5nIHJldmlzaW9uIDEuNjMKZGlmZiAtQiAtYiAtdSAtcjEuNjMgRG93bmxvYWRNZWRp
YXRvci5qYXZhCi0tLSBjb20vbGltZWdyb3VwL2dudXRlbGxhL2d1aS9kb3dubG9hZC9Eb3du
bG9hZE1lZGlhdG9yLmphdmEJMTEgSnVsIDIwMDUgMTU6NTM6MDggLTAwMDAJMS42MworKysg
Y29tL2xpbWVncm91cC9nbnV0ZWxsYS9ndWkvZG93bmxvYWQvRG93bmxvYWRNZWRpYXRvci5q
YXZhCTE3IEp1bCAyMDA1IDIyOjI0OjEyIC0wMDAwCkBAIC02LDYgKzYsNyBAQAogaW1wb3J0
IGphdmEudXRpbC5BcnJheUxpc3Q7CiBpbXBvcnQgamF2YS51dGlsLkFycmF5czsKIGltcG9y
dCBqYXZhLnV0aWwuQ29tcGFyYXRvcjsKK2ltcG9ydCBqYXZhLnV0aWwuTWFwOwogCiBpbXBv
cnQgamF2YXguc3dpbmcuQWJzdHJhY3RBY3Rpb247CiBpbXBvcnQgamF2YXguc3dpbmcuQWN0
aW9uOwpAQCAtMzQsNyArMzUsOSBAQAogaW1wb3J0IGNvbS5saW1lZ3JvdXAuZ251dGVsbGEu
Z3VpLmFjdGlvbnMuQml0emlMb29rdXBBY3Rpb247CiBpbXBvcnQgY29tLmxpbWVncm91cC5n
bnV0ZWxsYS5ndWkuYWN0aW9ucy5Db3B5TWFnbmV0TGlua1RvQ2xpcGJvYXJkQWN0aW9uOwog
aW1wb3J0IGNvbS5saW1lZ3JvdXAuZ251dGVsbGEuZ3VpLmFjdGlvbnMuTGltZUFjdGlvbjsK
K2ltcG9ydCBjb20ubGltZWdyb3VwLmdudXRlbGxhLmd1aS5hY3Rpb25zLlNlYXJjaEFjdGlv
bjsKIGltcG9ydCBjb20ubGltZWdyb3VwLmdudXRlbGxhLmd1aS5wbGF5bGlzdC5QbGF5bGlz
dE1lZGlhdG9yOworaW1wb3J0IGNvbS5saW1lZ3JvdXAuZ251dGVsbGEuZ3VpLnNlYXJjaC5T
ZWFyY2hJbmZvcm1hdGlvbjsKIGltcG9ydCBjb20ubGltZWdyb3VwLmdudXRlbGxhLmd1aS5z
ZWFyY2guU2VhcmNoTWVkaWF0b3I7CiBpbXBvcnQgY29tLmxpbWVncm91cC5nbnV0ZWxsYS5n
dWkudGFibGVzLkFic3RyYWN0VGFibGVNZWRpYXRvcjsKIGltcG9ydCBjb20ubGltZWdyb3Vw
LmdudXRlbGxhLmd1aS50YWJsZXMuQ29sdW1uUHJlZmVyZW5jZUhhbmRsZXI7CkBAIC00OCw5
ICs1MSwxMSBAQAogaW1wb3J0IGNvbS5saW1lZ3JvdXAuZ251dGVsbGEuZ3VpLnRoZW1lcy5U
aGVtZVNldHRpbmdzOwogaW1wb3J0IGNvbS5saW1lZ3JvdXAuZ251dGVsbGEuZ3VpLnV0aWwu
Q29yZUV4Y2VwdGlvbkhhbmRsZXI7CiBpbXBvcnQgY29tLmxpbWVncm91cC5nbnV0ZWxsYS5z
ZXR0aW5ncy5RdWVzdGlvbnNIYW5kbGVyOworaW1wb3J0IGNvbS5saW1lZ3JvdXAuZ251dGVs
bGEuc2V0dGluZ3MuU2VhcmNoU2V0dGluZ3M7CiBpbXBvcnQgY29tLmxpbWVncm91cC5nbnV0
ZWxsYS5zZXR0aW5ncy5TaGFyaW5nU2V0dGluZ3M7CiBpbXBvcnQgY29tLmxpbWVncm91cC5n
bnV0ZWxsYS51dGlsLkNvbW1vblV0aWxzOwogaW1wb3J0IGNvbS5saW1lZ3JvdXAuZ251dGVs
bGEudXRpbC5Qcm9jZXNzaW5nUXVldWU7CitpbXBvcnQgY29tLmxpbWVncm91cC5nbnV0ZWxs
YS51dGlsLlN0cmluZ1V0aWxzOwogCiAvKioKICAqIFRoaXMgY2xhc3MgYWN0cyBhcyBhIG1l
ZGlhdG9yIGJldHdlZW4gYWxsIG9mIHRoZSBjb21wb25lbnRzIG9mIHRoZQpAQCAtNTU1LDYg
KzU2MCw3IEBACiAJCW1lbnUuYWRkU2VwYXJhdG9yKCk7CiAJCW1lbnUuYWRkKG5ldyBKTWVu
dUl0ZW0oY2xlYXJBY3Rpb24pKTsKIAkJbWVudS5hZGRTZXBhcmF0b3IoKTsKKyAgICAgICAg
bWVudS5hZGQoY3JlYXRlU2VhcmNoTWVudSgpKTsKIAkJbWVudS5hZGQobmV3IEpNZW51SXRl
bShjaGF0QWN0aW9uKSk7CiAJCW1lbnUuYWRkKG5ldyBKTWVudUl0ZW0oYnJvd3NlQWN0aW9u
KSk7CiAJCW1lbnUuYWRkKG5ldyBKTWVudUl0ZW0oZWRpdExvY2F0aW9uQWN0aW9uKSk7CkBA
IC01NjQsNiArNTcwLDM4IEBACiAJCXJldHVybiBtZW51OwogICAgIH0KIAkKKyAgICBwcml2
YXRlIEpNZW51IGNyZWF0ZVNlYXJjaE1lbnUoKSB7CisgICAgICAgIEpNZW51IG1lbnUgPSBu
ZXcgSk1lbnUoR1VJTWVkaWF0b3IuZ2V0U3RyaW5nUmVzb3VyY2UoIkRPV05MT0FEX1NFQVJD
SF9NRU5VIikpOworICAgICAgICBEYXRhTGluZVtdIGxpbmVzID0gVEFCTEUuZ2V0U2VsZWN0
ZWREYXRhTGluZXMoKTsKKyAgICAgICAgaWYgKCBsaW5lcy5sZW5ndGggPT0gMCApICAvLyBp
cyB0aGVyZSBhbnkgZmlsZSBzZWxlY3RlZCA/CisgICAgICAgICAgICByZXR1cm4gbWVudTsK
KworICAgICAgICAvLy0tIG1ha2UgcGVyZm9ybSBvcmdpbmFsIHF1ZXJ5IC0tCisgICAgICAg
IC8vIGdldCBvcmdpbmFsIHF1ZXJ5CisgICAgICAgIERvd25sb2FkZXIgZG93bmxvYWRlciA9
ICgoRG93bmxvYWREYXRhTGluZSkgbGluZXNbMF0pLmdldERvd25sb2FkZXIoKTsKKyAgICAg
ICAgTWFwIHNlYXJjaEluZm9NYXAgPSAoTWFwKSBkb3dubG9hZGVyLmdldEF0dHJpYnV0ZSgK
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTZWFyY2hNZWRpYXRv
ci5TRUFSQ0hfSU5GT1JNQVRJT05fS0VZICk7CisgICAgICAgIGlmICggc2VhcmNoSW5mb01h
cCAhPSBudWxsICkgeworICAgICAgICAgICAgU2VhcmNoSW5mb3JtYXRpb24gc2VhcmNoSW5m
byA9IFNlYXJjaEluZm9ybWF0aW9uLmZyb21NYXAoIHNlYXJjaEluZm9NYXAgKTsKKyAgICAg
ICAgICAgIG1lbnUuYWRkKG5ldyBKTWVudUl0ZW0oIG5ldyBTZWFyY2hBY3Rpb24oIHNlYXJj
aEluZm8gKSApKTsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgLy8tLSBtYWtlIHNl
YXJjaCBmb3IgZmlsZW5hbWUgYWN0aW9uIC0tCisgICAgICAgIC8vIGdldCBuYW1lIG9mIHRo
ZSBmaWxlCisgICAgICAgIGphdmEubGFuZy5TdHJpbmcgZmlsZW5hbWUgPSAoKERvd25sb2Fk
RGF0YUxpbmUpIGxpbmVzWzBdKS5nZXRGaWxlTmFtZSgpOworICAgICAgICAvLyByZW1vdmUg
ZXh0ZW5zaW9uIC0gc2VhcmNoZXMgc2VhcmNoZXMgZmlsZW5hbWUgbm90IGluIHNwZWNpZmll
ZCBmb3JtYXQKKyAgICAgICAgaW50IGRvdFBvcyA9IGZpbGVuYW1lLmxhc3RJbmRleE9mKCcu
Jyk7CisgICAgICAgIGlmICggZG90UG9zID4gMCApCisgICAgICAgICAgICBmaWxlbmFtZSA9
IGZpbGVuYW1lLnN1YnN0cmluZyggMCwgZG90UG9zICk7CisgICAgICAgIGZpbGVuYW1lID0g
U3RyaW5nVXRpbHMucmVtb3ZlSWxsZWdhbENoYXJzKCBmaWxlbmFtZSApOworICAgICAgICAv
LyBjdXQgdGhlIGZpbGUgbmFtZSBpZiBuZWNlc3NhcnkKKyAgICAgICAgaWYgKCBmaWxlbmFt
ZS5sZW5ndGgoKSA+IFNlYXJjaFNldHRpbmdzLk1BWF9RVUVSWV9MRU5HVEguZ2V0VmFsdWUo
KSApCisgICAgICAgICAgICBmaWxlbmFtZSA9IGZpbGVuYW1lLnN1YnN0cmluZygwLCBTZWFy
Y2hTZXR0aW5ncy5NQVhfUVVFUllfTEVOR1RILmdldFZhbHVlKCkpOworICAgICAgICBtZW51
LmFkZChuZXcgSk1lbnVJdGVtKCBuZXcgU2VhcmNoQWN0aW9uKCBmaWxlbmFtZSApICkpOwor
ICAgICAgICAKKyAgICAgICAgcmV0dXJuIG1lbnU7CisgICAgfQorICAgIAogCXByaXZhdGUg
Sk1lbnUgY3JlYXRlQWR2YW5jZWRTdWJNZW51KCkgewogCQlKTWVudSBtZW51ID0gbmV3IEpN
ZW51KEdVSU1lZGlhdG9yLmdldFN0cmluZ1Jlc291cmNlCiAJCQkJKCJHRU5FUkFMX0FEVkFO
Q0VEX1NVQl9NRU5VIikpOwo=
--------------070705060508060304050602
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

_______________________________________________
gui-dev mailing list
[email protected]
http://www.limewire.org/mailman/listinfo/gui-dev

--------------070705060508060304050602--