Re: ovsqlite

Julien ÉLIE <[email protected]>
Newsgroups gmane.network.inn
Message-ID <[email protected]>
Hi Bo,

>> If I do not take into account the first 2 warnings, and manually
>> use sqlite3_prepare_v2, the remaining of the build works fine with
>> SQLite 3.8.7.1 from Debian Jessie.  Good news!
> 
> The minimum version requirement is based only on SQL language
> features. I ought to download SQLite 3.8.2 and test against it at
> some point.

Just tried to build INN with SQLite 3.8.2 and it appears that 
sqlite-helper uses sqlite3_malloc64() which is a function added only in 
SQLite 3.8.7.
I therefore suggest to require SQLite 3.8.7.



To silent a GCC warning, if you're OK with that, I also suggest to add 
"return 1" at the end of the main function (defined to return an int):

--- storage/ovsqlite/ovsqlite-server.c	(révision 10477)
+++ storage/ovsqlite/ovsqlite-server.c	(copie de travail)
@@ -2162,6 +2162,8 @@
      close_db();
      if (pidfile)
          unlink(pidfile);
+
+    return 1;
  }

  #else /* ! HAVE_SQLITE3 */


-- 
Julien ÉLIE

« Donner un sens plus pur aux mots de la tribu. » (Stéphane Mallarmé)
_______________________________________________
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.