Re: makehistory can generate duplicate lines

Hi Kamil,

> I applied both patches to debian sources, and I am runnning this
> server.
> Nothing exploded, seems to work.
> --8<---------------cut here---------------start------------->8---
> sudo -u news env PATH=$PATH:/usr/lib/news/bin makehistory -O -x -S
> --8<---------------cut here---------------end--------------->8---
> creates no duplicates.
> 
> Effect of
> --8<---------------cut here---------------start------------->8---
> sudo -u news env PATH=$PATH:/usr/lib/news/bin makehistory -f history.n
> --8<---------------cut here---------------end--------------->8---
> also looks better than before.

Many thanks for having taken the time to try these patches.
I'm glad that they have fixed the issues you reported.

They also worked fine on my news server.

I'll commit them soon.  I'll also add more comments to existing CNFS 
code I looked at yesterday (it was a bit hard to read and understand as 
there are very few comments, so better add some comments to record how 
it works).


[me]
> I think the next run of expireover will remove it from the overview
> as there's no history entry for it (I'll confirm tomorrow).

In fact not.  The article is still available from readers (advertised in 
OVER responses) and survived expiration even though no longer in the 
history.

-- 
Julien ÉLIE

« Qui habet aures audiendi, audiat. » (Évangiles)
-- 
inn-workers mailing list
[email protected]
https://lists.isc.org/mailman/listinfo/inn-workers