Re: New user - comments (and patches) to 0.4.6-1

Hello Stephan,

These patches are good, however, one suggestion, there are reasons for
the code to be in there the way it is. So any changes of this nature
should be made into #ifdef's so that the original code does not stop
working. We will modify the configure script to include these 'changes'
once they have been fully vetted or make them options in the preferences
as necessary.

For example, on your first one, your code will work and compile on
Windows but since there is no text output it will not bring up any
problems to a console thereby making it difficult to debug an issue.
So it would need to stay.

Also, what OS were you compiling on?

The ssl_certificate is very nice and probably should be there no matter
what.

Please re-provide the patches with ifdef's so that the main source pool
stays the same until the dev team can decide what to do.

Thanks,
Edward Haletky



On Fri, 2004-05-14 at 14:53, Stephan Dahl wrote:
> Hi,
> 
> I've recently started using Ayttm (my friends insist on using MSN, and I 
> won't install Windows :-).
> 
> It's a great piece of work, but I did have a few snags to work out out - 
> and I've added a few features I found useful.  Here's my change log, 
> with patches, in case someone else finds them useful.
> 
> To the dev team: Do you have a more formal process for submitting 
> patches than this mailing list?
> 
> ---
> 
> 
> Changelog to Ayttm
> 
> Base version: Ayttm 0.4.6-1
> 
> Summary
> -------
> 
> 1. Removed pop-up for unloaded modules
> 2. Added support for multiple SSL certificates per server
> 3. Changed status dialog title to show number of connected contacts
> 4. Fixed image_2_jpc undefined symbol
> 5. Bug in configure's detection of artsc
> 6. Changed format of contact on/offline message to include timestamp
> 
> 
> Change motivation and description
> ---------------------------------
> 
> 1. Removed pop-up for unloaded modules
> 
> I kept getting a popup on startup with the text:
> 
> Plugin /usr/local/lib/ayttm/yahoo2.la has not been loaded because of an 
> error:
> /usr/local/lib/ayttm/yahoo2.so: undefined symbol: image_2_jpc
> 
> I don't use yahoo, so I could care less - but I still had to click
> on the #%? popup, which was modal and quickly buried in other frames.
> The only possible response is OK, so it's really just noise. I removed 
> the popup and redirected the text to stderr.
> 
> Patch#1: Change to:
> src/plugin.c
> 
> 
> 2. Added support for multiple SSL certificates per server
> 
> The messenger.hotmail.com server kept switching SSL certificate on me -
> I suspect that it is really two servers behind a load balancer.
> 
> I changed the implementation of the SSL certificate store (in
> $HOME/.ayttm/certs) to support any number of stored certificates
> for a specified server/port combination. If any of the certs match,
> the connection is quietly accepted. Of course, all certs must be
> explicitly approved by the user.
> 
> Also added a popup warning when a new, signed certificate is presented,
> noting that the signature is valid - before, any signed certificate was
> quietly accepted.
> 
> Patch#2: Change to:
> src/ssl_certificate.c
> src/ssl_certificate.h
> 
> 
> 
> 3. Changed status dialog title to show number of connected contacts
> 
> I have disabled sound for ayttm (it won't work for me - I'll look into
> it later), and keep the status window on another desktop or minimized.
> Thus, I'd like to get more information from the panel where all the
> application titles are shown - "Ayttm 0.4.6-1" is really void of meaning
> after the first few days :->. I changed it to show number of online
> contacts. This is more useful, IMO.
> 
> Also tweaked the duration of the title change when a contact goes on-
> or offline from 5 to 10 seconds. I don't glance there often, and I like
> my desktop quiet.
> 
> Patch#3: Change to:
> src/status.c
> 
> 
> 4. Fixed image_2_jpc undefined symbol
> 
> Same as 0.4.6-11 - I got a Yahoo account just for kicks, and wanted to 
> see if I could get it to work.
> src/image_window.c: Moved definitions outside #ifdef
> Kind of obsoletes change #1, but I still think that popup was annoying.
> 
> Patch#4: Change to:
> src/image_window.c
> 
> 
> 5. Bug in configure's detection of artsc
> 
> The configure script did not detect aRTs support - so I had to manually
> change config.h to #define ARTS_SOUND (and, after some hassle, #define
> ARTS_FREE_IS_BROKEN as well).
> 
> Also had to change src/Makefile to include
> EB_CFLAGS = ... -I/opt/kde2/include/artsc
> EB_LIBS = ... -L/opt/kde2/lib -lartsc
> 
> I don't have the patience today to debug the configure script, so no patch.
> 
> 
> 6. Changed format of contact on/offline message to include timestamp
> 
> Added a timestamp to the contact online/offline status message at the
> bottom of the status window. Had to remove code in status.c which
> disables messages with digits in them - unknown why, but it hasn't
> blown up yet...
> 
> Included in patch#3
> 
> 
> 
> Hope you like it,


-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click