Re: Possible format string vulnerability

--===============6900499558339819720==
Content-Type: multipart/alternative; boundary=047d7beb98aaf59ba3051e1184e2

--047d7beb98aaf59ba3051e1184e2
Content-Type: text/plain; charset=UTF-8

Ok, I've looked through the code, and these are my findings:

1. The code should have been inside an #ifdef block, but for some reason it
is inside a #ifndef block, which inverts the meaning of the condition.

2. The snprintf and debug_print statements should really just be merged
into a single statement with no actual need for debug_buff

Unfortunately this code dates back to the very first revision, so it
probably inherited from "everybuddy", but I don't have the time to go into
the cvs history for EB.

I've fixed this and hope someone can test it thoroughly.

Philip

--047d7beb98aaf59ba3051e1184e2
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Ok, I&#39;ve looked through the code, and these are my fin=
dings:<div><br></div><div>1. The code should have been inside an #ifdef blo=
ck, but for some reason it is inside a #ifndef block, which inverts the mea=
ning of the condition.</div><div><br></div><div>2. The snprintf and debug_p=
rint statements should really just be merged into a single statement with n=
o actual need for debug_buff</div><div><br></div><div>Unfortunately this co=
de dates back to the very first revision, so it probably inherited from &qu=
ot;everybuddy&quot;, but I don&#39;t have the time to go into the cvs histo=
ry for EB.</div><div><br></div><div>I&#39;ve fixed this and hope someone ca=
n test it thoroughly.</div><div><br></div><div>Philip</div><div><br></div><=
div class=3D"gmail_extra"><div class=3D"gmail_quote"><br></div>
</div></div>

--047d7beb98aaf59ba3051e1184e2--


--===============6900499558339819720==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------

--===============6900499558339819720==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Ayttm-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ayttm-users

--===============6900499558339819720==--