Re: [Fwd: Bug#264775: segfaults on hostnames that only have IPv6 addresses]

In the immortal words of Philipp Kern:
> On Mi, 2004-08-18 at 20:19, Erik Fears wrote:
> > We don't do much sanity checking when receiving a connection notice
> > because we assumed if it works once, it will always work.
> 
> That's probably right, but we talk about people who use a BOPM
> pre-compiled by a distribution. They don't do it on their own.
> 
> Couldn't there be some kind of sanity checking instead of just bailing
> out with a segmentation fault? Just a failure quit with a descriptive
> message (like ``The connection notice contains some malformed values;
> bailing out.'')?

The segfault should definitely be fixed (presumably by doing sanity
checking on input from the network) for security reasons if nothing
else.  But in this case, it's not necessary to bail completely, as it
is possible that some but not all connect notices will cause the
problem.  It may be sufficient to log it and move on (the message
above seems pretty good).

%%  Christopher A. Bongaarts  %%  [email protected]       %%
%%  Internet Services         %%  http://umn.edu/~cab  %%
%%  University of Minnesota   %%  +1 (612) 625-1809    %%