bugfix for proxy-module related to isupport changes

Valentin Batz <[email protected]> Fri, 27 Feb 2004 05:39:18 +0100

Newsgroups	gmane.network.irc.irssi.devel
Message-ID	<14778380.1077860358@[192.168.0.2]>

Hi there,

there is a bug in the proxy module in dump.c. If the server on the 
irssi-proxy side is not connected and the client is connecting to the 
irssi-proxy, it will crash. It's related to the isupport changes. It 
happens because it doesn't check for server != NULL, before it checks for 
server->support_sent.

Patch included

Best regards

Valentin Batz
[email protected]
(senneth@IRCnet/freenode)

src.irc.proxy.dump.c.diff (application/octet-stream, 579 B)

--- src/irc/proxy/dump.c.old	2004-02-27 05:06:27.000000000 +0100
+++ src/irc/proxy/dump.c	2004-02-27 05:06:50.000000000 +0100
@@ -235,7 +235,7 @@
 	else
 		proxy_outdata(client, ":%s 004 %s %s %s oirw abeIiklmnopqstv\n", client->proxy_address, client->nick, client->proxy_address, IRSSI_VERSION);
 
-	if (client->server->isupport_sent) {
+	if ((client->server != NULL) && (client->server->isupport_sent)) {
 		isupport_out = g_string_new(NULL);
 		g_string_sprintf(isupport_out, ":%s 005 %s ", client->proxy_address, client->nick);
 		/* FIXME: should be limited to 15 params */