Re: Bug#408579: [Fwd: Bug#408579: lftp: option [-p port] ignored if a path is specified]

found 408579 3.5.10-1
thanks

On Mon, Feb 26, 2007 at 06:06:41PM +0300, Alexander V. Lukyanov wrote:
> > > Depending on the specification of a path ("/" is considered as a path)
> > > or not, the option [-p port] can be ignored.
> 
> This patch should fix the problem.

Hello,

Sorry for the quite late feedback..

There is still an issue :
$ ltp proto://user:pass@host:PORT/path
is OK

while:
$ lftp -p PORT proto://user:pass@host/path
cd: Login failed: Password required

Don't know whether a new bug must be opened or not ..

Best regards,

-- 
Simon Paillard

> Index: commands.cc
> ===================================================================
> RCS file: /home/lav/cvsroot/lftp/src/commands.cc,v
> retrieving revision 1.261.2.1
> diff -u -p -r1.261.2.1 commands.cc
> --- commands.cc	14 Dec 2006 09:29:06 -0000	1.261.2.1
> +++ commands.cc	26 Feb 2007 15:05:32 -0000
> @@ -909,10 +909,17 @@ Job *CmdExec::builtin_open()
>  	    delete url;
>  	    url=new ParsedURL(u);
>  	 }
> -	 if(user)
> +	 if(user || port)
>  	 {
>  	    url->user=user;
>  	    url->pass=pass;
> +	    if(user)
> +	    {
> +	       url->user=user;
> +	       url->pass=pass;
> +	    }
> +	    if(port)
> +	       url->port=port;
>  	    char *host1=url->Combine();
>  	    delete url;
>  	    url=new ParsedURL(host1);