Re: CCC and RFC4217 compliance?

On Thu, Feb 18, 2010 at 06:40:46AM -0800, Alexander V. Lukyanov wrote:
> On Wed, Feb 17, 2010 at 05:27:40PM -0800, Ray Van Dolson wrote:
> > It sounds like lftp doesn't properly support a bi-directional SSL
> > shutdown when CCC is in use as described in RFC4217 section 12.3.  Is
> > this the case?
> 
> Would this patch fix the problem? I have no server to test this on.
> 
> Index: ftpclass.cc
> ===================================================================
> RCS file: /home/lav/cvsroot/lftp/src/ftpclass.cc,v
> retrieving revision 1.461
> diff -u -p -r1.461 ftpclass.cc
> --- ftpclass.cc	15 Sep 2009 07:56:30 -0000	1.461
> +++ ftpclass.cc	18 Feb 2010 14:27:29 -0000
> @@ -4136,6 +4148,7 @@ void Ftp::CheckResp(int act)
>     case Expect::CCC:
>        if(is2XX(act))
>        {
> +	 conn->control_send->PutEOF();
>  	 state=WAITING_CCC_SHUTDOWN;
>  	 conn->waiting_ssl_timer.Reset();
>        }
> 

That does seem to work.... still testing, but so far so good.

(Tested against lftp 3.7.14 w/ Fedora 11)

Ray