Re: [Fwd: bug 1110812 - 4Gigbug.patch does not work in Windows]

Donovan Baarda <[email protected]> Mon, 20 Mar 2006 13:43:05 +0000
Newsgroups gmane.network.librsync.devel
Organization http://minkirri.apana.org.au/~abo/
Message-ID <[email protected]>
On Mon, 2006-03-20 at 18:18 +0530, Sekar Vembu wrote:
> Hi,
> Subsequent to my original email, I think we have fixed the large file 
> problem in Windows too. We have made minor modifications to three files. 
> We have tested this and it seems to work for us. I am attaching the 
> three files with this email.
> 1. buf.c
> 2. librsync.h
> 3.PcBuild\librsync-config.h
> 
> The following are the cvs-diff for those three files. Hope some expert 
> will review this and check this in to the librsync CVS. If there is a 
> problem with these changes please let me know.

Please submit patches at the SF patch tracker...

Also, looking at this, I have a feeling this is compiler dependant,
rather than just WIN32 dependent. I suspect this stuff should be handled
by configure, rather than peppering the code with more #if WIN32 stuff.
Note that PCBuild/librsync-config.h should be auto-generated by running
configure with a MSC system.

In any case, thanks for this... if no one else gets around to it before
me, I'll look into it and see what the best approach for this is...

-- 
Donovan Baarda <[email protected]>
http://minkirri.apana.org.au/~abo/



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642