[Licq-devel] Re: Commit 5026
Jon Keating <[email protected]>
| Newsgroups | gmane.network.licq.devel |
|---|---|
| Message-ID | <[email protected]> |
On Tuesday 17 July 2007 21:50, Erik Johansson wrote: > addToModifyUsers() should take a const std::string reference as second > arg to avoid unnecessary copies. The point is to force a copy. One of the users, Crazy_Hopper on IRC was reporting a crash and it was fixed by not using a reference as the parameter. Something may be strange with his STL version. I'll try and confirm with him about that. > Additionally, I think that function declarations should include the > name for all parameters. Added. > line 4305: I think if (pending.length()) should be if (!pending.empty()). Perhaps you should add that to the coding style? if (pending.length()) = If has some length if (pending.size()) = If has some size if (!pending.empty()) = If not empty All seem the same to me... Jon -- ________________________________________________________ Jon Keating ICQ: 16325723 [email protected] MSN: [email protected] http://www.licq.org GPG: 2290A71F http://www.thejon.org HOME: Minamiashigara, Japan