Re: [Licq-devel] Licq 1.3.9 released

This is a multi-part message in MIME format.
--------------060802010705010402020808
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2010-05-17 04:50, Danila wrote:
> Hi
> After refusing authorization licq it is disconnect from a server. The
> version 1.3.9 ,qt4-gui,OS FreeBSD-8.0
> Log:
> 08:45:03: [SRV] Authorization request from 509409.
> 08:45:17: [SRV] Refusing authorization to user 509409 (#22192)...
> 08:45:47: [WRN] error during receiving from server socket :-((
>                  Connection reset by peer
> 08:45:47: [SRV] Dropping server connection.
> 08:45:47: Event #22192 is still on the running queue!
>
> Thanks

Hi,
I'm sorry I failed to reproduce this before packaging 1.3.9.
Trying again I found that this only happens if the refuse message is 
empty, i.e. a simple workaround is to always input at least a space 
before sending.

I've attached a patch that fixes this properly. I'll commit it tomorrow 
to make sure it's included in future Licq releases.

Thanks for reporting the fault.

/Anders

--------------060802010705010402020808
Content-Type: text/x-diff;
 name="licq-1.3.9-icqdisconnect.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="licq-1.3.9-icqdisconnect.patch"

Index: src/buffer.cpp
===================================================================
--- src/buffer.cpp	(revision 7352)
+++ src/buffer.cpp	(working copy)
@@ -446,6 +446,8 @@
   PackUnsignedShort(size);
   if (data != NULL)
     Pack(data, size);
+  else
+    PackChar('\0');
   return getDataPosWrite() - size;
 }
 

--------------060802010705010402020808--