Re: [Licq-devel] Some GUI patches

On 2011-11-13 19:31, Jörg Mensmann wrote:
> Hi,
>
> here is bunch of patches for the Qt4-GUI that fix session handling and
> global shortcuts on KDE and make the display of remote user time less
> intrusive.
>
> ciao
>    Jörg
>

Hi,
thanks for the patches. I have some comments though.

Session handling:
According to [1], the -session parameter is mandatory. Is there any KDE 
documentation indicating that this should be different for KDE 
applications? Otherwise I would prefer to keep -session but fix the arg 
parsing instead to handle both "-session" and "-s".
Also, now that I look at the current session handling, it will not 
preserve any parameters for other plugins or licq (for example basedir) 
so I think this needs a bigger makeover... I'll have to give all of this 
some more thought...

Global shortcuts:
The global shortcut works fine with both qt4-gui and kde4-gui here.
Is there any specific key(s) that only works when doing it the KDE way?
Are you having problems when building without KDE support or only with?

Remote time:
I'm not against hiding the remote user's time (when unknown or as a user 
setting) but then we loose the typing notification indicator. I'm open 
to suggestions on how to show typing notifications instead.
I'll drop the seconds from the display though, I agree that those aren't 
needed.

/Anders


[1] http://doc.trolltech.com/4.7/qsessionmanager.html#setRestartCommand