Re: [Licq-devel] Some GUI patches

On 2011-11-14 21:45, Jörg Mensmann wrote:
> Anders Olofsson<[email protected]>  wrote:
>> According to [1], the -session parameter is mandatory. Is there any
>> KDE documentation indicating that this should be different for KDE
>> applications?
>
> I couldn't find anything in the KApplication docs. However, all KDE
> applications only list "--session" as a supported option when called
> with "--help-qt".
>
>> Also, now that I look at the current session handling, it will not
>> preserve any parameters for other plugins or licq (for example
>> basedir) so I think this needs a bigger makeover...
>
> Yes, it looks quite incomplete to me, too. The patch is mainly a
> workaround for the two issues.

I'm not very familiar with session management but the purpose should be 
to restore the state of an application as much as possible after a 
restart. As Licq doesn't have any state handling other than normal 
configuration I'm not sure it worth pretending anything by having 
support for the parameter at all.
Do you know if the window manager does anything useful for us when the 
session parameter is present? Otherwise I think it could just as well be 
removed until someone wants to implement proper session support for Licq.


>> The global shortcut works fine with both qt4-gui and kde4-gui here.
>
> Without the patch global shortcuts didn't work at all for me, neither
> with kde4-gui nor with pure qt4-gui. I tried several types of key combos
> (Meta+I, Ctrl+I, etc.), but they would always go to the window in focus,
> not Licq. I'm running Fedora 15 with KDE 4.6.5.

Do you by any chance have Num Lock active? I did some testing and found 
that the current event grabbing with X only worked if Caps Lock and Num 
Lock were off. I just committed a fix for this, please check if it works 
better for you now.


>> I'm not against hiding the remote user's time (when unknown or as a
>> user setting) but then we loose the typing notification indicator. I'm
>> open to suggestions on how to show typing notifications instead.
>
> Well, there is still the contact's name in the tabbar which changes
> color in this case (if tabs are enabled), but I get the point. Other
> clients often show a temporary "user is typing" at the end of the chat
> history. We could also use the pen icon that appears in the contact list
> as a notification, placing it where the user time display used to be
> (with a flashy background color).

Something temporary in the history area sounds complicated (that code is 
complicated enough as it is). I think I prefer having something in the 
window rather than messing with the window title or the window icon, so 
having a pen icon or similar when he remote time isn't displayed might 
be the way to go. I'll try it out and see how it looks.

/Anders