Re: [Fwd: Bug#214167: lsh-client: Please remove pesky identity file error output]

Timshel Knoll <[email protected]> writes:

> If I connect to a host lshc always complains about missing identity
> file. Since I don't use public key authentication this "error" should be
> removed and only occur if lshc is in verbose mode:
> 
> djmaecki@marvin:~$ lshc just.a.host
> lshc: Failed to open `/home/djmaecki/.lsh/identity' for reading: No such file or directory
> Password for djmaecki:

That suggestion makes sense. The following patch (relative to the
current cvs) should fix this.

diff -u -a -r1.190 lsh.c
--- src/lsh.c	15 Sep 2003 15:17:55 -0000	1.190
+++ src/lsh.c	5 Oct 2003 20:33:30 -0000
@@ -275,7 +275,7 @@
   fd = open(name, O_RDONLY);
   if (fd < 0)
     {
-      werror("Failed to open `%z' for reading %e\n", name, errno);
+      verbose("Failed to open `%z' for reading %e\n", name, errno);
       lsh_string_free(tmp);

       return make_object_list(0, -1);

I'm not sure it makes sense with a new 1.4.x release for this, but
I'll check this in on the 1.5.x branch right away.

Two other comments, one of them important: lsh-1.4.2 has a major
security bug. You should try to get a 1.4.3 package out as soon as
possible, if you haven't done that already (I guess I should try to
figure out how to use the debian packet tracker to get mail about
releases of new lsh packages).

And there's an lsh bugzilla project at
http://bugzilla.lysator.liu.se/index.cgi which can be used to file
bugs, wish list items etc for lsh.

Best regards,
/Niels