Re: Can't get X forwading working

Kaloian Doganov <[email protected]> writes:

> The same example case goes a little further when I try to execute it
> with GNU lsh 2.0.3:

It seems this was a bug introduced in the string reorganization before
lsh-2.0. With the below patch, x11 forwarding works again, at least
for me. I'll see when I get the time for a lsh-2.0.4 bugfix release.

(I thought I wrote some proper X11 testcase a long time ago, using
some fake x11 server, but appearantly there's nothing like that...
Suggestions for automatic regression testing of the x11 forwarding are
appreciated).

Regards,
/Niels


diff -u -a -p -r1.26 client_x11.c
--- src/client_x11.c	16 Nov 2003 18:40:37 -0000	1.26
+++ src/client_x11.c	4 Jun 2007 20:55:02 -0000
@@ -211,6 +211,7 @@ do_client_channel_x11_receive(struct ssh
         /* The small initial window size should ensure that all the
 	   data fits. */
 	lsh_string_write_string(self->buffer, self->i, data);
+	self->i += lsh_string_length(data);
         lsh_string_free(data);

 	buffer = lsh_string_data(self->buffer);