[bug #19818] commonShared: shared_prio & shared_dir always Not_found

vbnuy6 <[email protected]>
Newsgroups gmane.network.mldonkey.bugs
Message-ID <[email protected]>
URL:
  <http://savannah.nongnu.org/bugs/?19818>

                 Summary: commonShared:  shared_prio & shared_dir always
Not_found
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: gyhu94t
            Submitted on: Tuesday 05/08/2007 at 02:38
                Category: Core
                Severity: 3 - Normal
              Item Group: Program malfunction
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 
                 Release: 2.8.5
        Operating System: MinGW W2K/WinXP
         Binaries Origin: CVS / Self compiled
                CPU type: Intel x86

    _______________________________________________________

Details:

I was trying to write a patch (at
http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?p=24608#24608
not that it matters).  Is it true that 
shared_prio
shared_dir
in src/daemon/common/commonShared.ml never actually work, at least when
called from src/daemon/common/commonUploads.ml?
If so does it means share priorities never have any effect?

Experiment:
-Change "with Not_found -> " return values to make it obvious.  
-set verbosity favoured
 (patch attached)
-findstr "favoured" "C:\Program Files\mlnet\mlnet.log"

Result: ("pri" and "cdir" are the relevant ones)
2007/05/08 02:30:06 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:30:07 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
F....
2007/05/08 02:30:10 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:30:22 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
H....
2007/05/08 02:30:23 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:30:28 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
m....
2007/05/08 02:30:30 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:30:42 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:30:44 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:30:48 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:30:48 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:30:49 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:30:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:30:51 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
A....
2007/05/08 02:30:52 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:31:03 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
綵....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
b....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
C....
2007/05/08 02:31:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:31:18 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:31:19 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
0....
2007/05/08 02:31:21 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:31:24 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:31:44 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:31:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:31:50 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
(....
2007/05/08 02:31:51 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
0....
2007/05/08 02:32:01 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:32:06 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
[....
2007/05/08 02:32:12 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
J....
2007/05/08 02:32:17 [cUp] favoured str= fav=0 pri=999 cdir=phytoplankton 
綵....
etc.

Thanks for all your work.





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tuesday 05/08/2007 at 02:38  Name: bug-commonShared.patch.txt  Size:
3kB   By: gyhu94t
patch for experiment
<http://savannah.nongnu.org/bugs/download.php?file_id=12715>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?19818>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.