Re: [monitoring-plugins/monitoring-plugins] Update .travis.yml (#1440)
Sven Nierlein <[email protected]> Mon, 07 Nov 2016 14:36:18 -0800
| Newsgroups | gmane.network.nagios.devel,gmane.network.monitoring.plugins.devel |
|---|---|
| Message-ID | <monitoring-plugins/monitoring-plugins/pull/1440/[email protected]> |
----==_mimepart_582101e2a3df1_30a03ff2a3b0f2b8268893
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
I'd say both works. Your solution is nicer because it doesn't run grep and
wc with sudo. But we can just remove sudo completly, because `ip addr show`
works with user permissions as well and we just need to keep the sudo before
the `sed`.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/monitoring-plugins/monitoring-plugins/pull/1440#issuecomment-258985729
----==_mimepart_582101e2a3df1_30a03ff2a3b0f2b8268893
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<p>I'd say both works. Your solution is nicer because it doesn't run grep a=
nd wc with sudo. But we can just remove sudo completly, because <code>ip ad=
dr show</code> works with user permissions as well and we just need to keep=
the sudo before the <code>sed</code>.</p>
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />You are receiving this because you are subscribed to this thread.<=
br />Reply to this email directly, <a href=3D"https://github.com/monitoring=
-plugins/monitoring-plugins/pull/1440#issuecomment-258985729">Reply to this=
email on GitHub</a>, or <a href=3D"https://github.com/notifications/unsubs=
cribe-auth/AFQl2bVe9bGW23eys9miVr0Bc3IRWC0uks5q76figaJpZM4KryeK">mute the t=
hread</a>.<img alt=3D"" height=3D"1" src=3D"https://github.com/notification=
s/beacon/AFQl2asfpCuKtvbp3BIyAH2mEIR_go04ks5q76figaJpZM4KryeK.gif" width=3D=
"1" /></p>
<div itemscope itemtype=3D"http://schema.org/EmailMessage">
<div itemprop=3D"action" itemscope itemtype=3D"http://schema.org/ViewAction=
">
<link itemprop=3D"url" href=3D"https://github.com/monitoring-plugins/moni=
toring-plugins/pull/1440#issuecomment-258985729"></link>
<meta itemprop=3D"name" content=3D"View Pull Request"></meta>
</div>
<meta itemprop=3D"description" content=3D"View this Pull Request on GitHub"=
></meta>
</div>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_version"=
:"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"Gi=
tHub"},"entity":{"external_key":"github/monitoring-plugins/monitoring-plugi=
ns","title":"monitoring-plugins/monitoring-plugins","subtitle":"GitHub repo=
sitory","main_image_url":"https://cloud.githubusercontent.com/assets/143418=
/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"htt=
ps://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-=
9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://git=
hub.com/monitoring-plugins/monitoring-plugins"}},"updates":{"snippets":[{"i=
con":"PERSON","message":"@sni in #1440: I'd say both works. Your solution i=
s nicer because it doesn't run grep and wc with sudo. But we can just remov=
e sudo completly, because `ip addr show` works with user permissions as wel=
l and we just need to keep the sudo before the `sed`."}],"action":{"name":"=
View Pull Request","url":"https://github.com/monitoring-plugins/monitoring-=
plugins/pull/1440#issuecomment-258985729"}}}</script>
----==_mimepart_582101e2a3df1_30a03ff2a3b0f2b8268893--