SF.net SVN: nagiosplug:[2088] nagiosplug/trunk/plugins/check_disk.c

Revision: 2088
          http://nagiosplug.svn.sourceforge.net/nagiosplug/?rev=2088&view=rev
Author:   dermoth
Date:     2008-11-20 08:14:41 +0000 (Thu, 20 Nov 2008)

Log Message:
-----------
Add comment to recent check_disk patch

Modified Paths:
--------------
    nagiosplug/trunk/plugins/check_disk.c

Modified: nagiosplug/trunk/plugins/check_disk.c
===================================================================
--- nagiosplug/trunk/plugins/check_disk.c	2008-11-19 06:45:18 UTC (rev 2087)
+++ nagiosplug/trunk/plugins/check_disk.c	2008-11-20 08:14:41 UTC (rev 2088)
@@ -637,8 +637,11 @@
       se->group = group;
       set_all_thresholds(se);
 
-      /* With autofs, it is required to stat() the path before populating the mount_list */
+      /* With autofs, it is required to stat() the path before re-populating the mount_list */
       stat_path(se);
+      /* NB: We can't free the old mount_list "just like that": both list pointers and struct
+       * pointers are copied around. One of the reason it wasn't done yet is that other parts
+       * of check_disk need the same kind of cleanup so it'd better be done as a whole */
       mount_list = read_file_system_list (0);
       np_set_best_match(se, mount_list, exact_match);
 


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/