Re: [PATCH/PULL] New plugin: check_dbi

Hi,

On Wed, Jun 06, 2012 at 12:38:42PM +0200, Holger Weiß wrote:
> * Sebastian Harl <[email protected]> [2012-06-06 11:55]:
> > On Fri, Apr 08, 2011 at 11:45:11AM +0200, Sebastian Harl wrote:
> > > The latest version of the plugin can be found at
> > > <http://oss.teamix.org/projects/nagiosplug/repository/entry/plugins/check_dbi.c?rev=sh%2Fcheck_dbi>.
> > > 
> > > I'm looking forward to comments, suggestions and (of course) patches :-)
> > 
> > As there are rumours about a new release, I'd like to point out this new
> > plugin again. Any feedback about whether this is interesting for the
> > nagiosplugins project and/or needs some more work would be appreciated.
> > If you prefer a Github pull request instead, I'd be happy to do that as
> > well.
> 
> While we currently don't have the resources to include many new plugins,
> I think this one _is_ interesting.  At first glance, the code looks fine
> to me.  If you (or someone else) provide some test cases for this
> plugin, and if nobody objects, I'd consider it for inclusion.

I've added a few test-cases and opened a pull request on Github. Imho,
that should be used for further comments, objections, etc. ;-)

> This won't make it into the upcoming release, but we could probably
> import it right afterwards.

Great! :-)

Cheers,
Sebastian

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________________
Nagios Plugin Development Mailing List Nagiosplug-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel
::: Please include plugins version (-v) and OS when reporting any issue. 
::: Messages without supporting info will risk being sent to /dev/null

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAk/RxjgACgkQEFEKc4UBx/wDEwCeJ8u0Ah/0DIse1PVOEj2j3hCU
9O8AoILcad97dXpkqVHz01/tahb/swlK
=0mTX
-----END PGP SIGNATURE-----