Re: [ nagiosplug-Bugs-3614716 ] np_net_ssl_read fails to take SSL_WANT_READ into account
Holger Weiß <[email protected]>
| Newsgroups | gmane.network.nagios.plugins.devel |
|---|---|
| Organization | Freie Universität Berlin |
| Message-ID | <[email protected]> |
* William Leibzon <[email protected]> [2013-07-16 15:57]: > On Tue, Jul 16, 2013 at 3:31 PM, Holger Weiß <[email protected]> wrote: > > * William Leibzon <[email protected]> [2013-07-16 14:28]: > >> and SSL_WANT_READ needs to be handled. > > > > I was going to check whether setting SSL_MODE_AUTO_RETRY¹ would be a > > better choice. When using blocking I/O, I don't see the point in having > > OpenSSL's I/O functions return SSL_WANT_READ. I just wanted to make > > sure this won't break GnuTLS (or older OpenSSL versions, but I think > > they introduced SSL_MODE_AUTO_RETRY ages ago). If GnuTLS supports > > SSL_MODE_AUTO_RETRY, I'd happily pull a commit that sets this mode > > (maybe wrapped in an "#ifdef SSL_MODE_AUTO_RETRY" if it's only supported > > by newer GnuTLS versions). > > Yeah, that's even better. It was added in 0.9.6 which is 2004. Thanks for checking. I committed this now: https://github.com/nagios-plugins/nagios-plugins/commit/f4b90cabc002 Holger ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________________ Nagios Plugin Development Mailing List Nagiosplug-devel-5NWGOfrQmneRv+LV9MX5upmplPMkL2fr@public.gmane.orget Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel ::: Please include plugins version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null