[ nagiosplug-Bugs-3614879 ] Incocistencies between plugins versions

Bugs item #3614879, was opened at 2013-08-06 01:15
Message generated for change (Comment added) made by hweiss
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3614879&group_id=29880

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General plugin execution
Group: None
>Status: Pending
>Resolution: Fixed
Priority: 6
Private: No
Submitted By: Simon Kainz (simonkainz)
Assigned to: Holger Weiss (hweiss)
Summary: Incocistencies between plugins versions

Initial Comment:
I took nagios-plugins from github and noticed the following: Using version 1.4.16.89.gbfe6, the processing of waring/critical ranges in check_snmp seems to be broken. 

OS: Debian Wheezy 64bit
Compiler: 6cc

I built all 3 versions by myself from source.

I uses these 3 versions for a test:

$ for i in nagios-plugins-1.4.15 nagios-plugins-1.4.16 nagios-plugins; do $i/plugins/check_snmp -P 2c -c public -H <printerip> -o .1.3.6.1.2.1.43.18.1.1.7.1.1 -w 800:1200 -c 850:1150 -v -v -v -V ; done
check_snmp v1.4.15 (nagios-plugins 1.4.15)
check_snmp v1.4.16 (nagios-plugins 1.4.16)
check_snmp v1.4.16.89.gbfe6 (nagios-plugins 1.4.16)

Running those 3  results in the following:

$ for i in nagios-plugins-1.4.15 nagios-plugins-1.4.16 nagios-plugins; do $i/plugins/check_snmp -P 2c -c public -H <printerip> -o .1.3.6.1.2.1.43.18.1.1.7.1.1 -w 800:1200 -c 850:1150 -v -v -v ; done
/usr/bin/snmpget -t 1 -r 5 -m '' -v 2c [authpriv] 129.27.9.62:161 .1.3.6.1.2.1.43.18.1.1.7.1.1
iso.3.6.1.2.1.43.18.1.1.7.1.1 = INTEGER: 1104
Processing oid 1 (line 1)
  oidname: iso.3.6.1.2.1.43.18.1.1.7.1.1
  response:  = INTEGER: 1104
SNMP OK - 1104 | iso.3.6.1.2.1.43.18.1.1.7.1.1=1104 
/usr/bin/snmpget -t 1 -r 5 -m '' -v 2c [authpriv] 129.27.9.62:161 .1.3.6.1.2.1.43.18.1.1.7.1.1
iso.3.6.1.2.1.43.18.1.1.7.1.1 = INTEGER: 1104
Processing oid 1 (line 1)
  oidname: iso.3.6.1.2.1.43.18.1.1.7.1.1
  response:  = INTEGER: 1104
SNMP OK - 1104 | iso.3.6.1.2.1.43.18.1.1.7.1.1=1104 
/usr/bin/snmpget -t 1 -r 5 -m '' -v 2c [authpriv] 129.27.9.62:161 .1.3.6.1.2.1.43.18.1.1.7.1.1
iso.3.6.1.2.1.43.18.1.1.7.1.1 = INTEGER: 1104
Processing oid 1 (line 1)
  oidname: iso.3.6.1.2.1.43.18.1.1.7.1.1
  response:  = INTEGER: 1104
SNMP CRITICAL - *1104* | iso.3.6.1.2.1.43.18.1.1.7.1.1=1104


So the last plugin reports CRITIAL, altough the value reported lies perfectly withing the defined warning/critical ranges. 
Maybe I'm doing something wrong, but still seems like a bug to me.

Regards, Simon


----------------------------------------------------------------------

>Comment By: Holger Weiss (hweiss)
Date: 2013-08-21 06:12

Message:
We (hopefully) fixed this properly now, you might want to try the current
'master' branch without reverting the mentioned commit.  Please let us know
if you still encounter any issues.

Thanks a lot for your report, this was quite a major regression and I'm
happy you found it before we created the new release.

----------------------------------------------------------------------

Comment By: Simon Kainz (simonkainz)
Date: 2013-08-06 02:05

Message:
Hi!

Works now! Please see the output below:


$ for i in nagios-plugins-1.4.15 nagios-plugins-1.4.16 nagios-plugins; do
$i/plugins/check_snmp -P 2c -c public -H 129.27.9.62 -o
.1.3.6.1.2.1.43.18.1.1.7.1.1 -w 800:1200 -c 850:1150 -v -v -v  -V; done

check_snmp v1.4.15 (nagios-plugins 1.4.15)
check_snmp v1.4.16 (nagios-plugins 1.4.16)
check_snmp v1.4.16.90.g9bb2 (nagios-plugins 1.4.16)


g$ for i in nagios-plugins-1.4.15 nagios-plugins-1.4.16 nagios-plugins; do
$i/plugins/check_snmp -P 2c -c public -H 129.27.9.62 -o
.1.3.6.1.2.1.43.18.1.1.7.1.1 -w 800:1200 -c 850:1150 -v -v -v  ; done
/usr/bin/snmpget -t 1 -r 5 -m '' -v 2c [authpriv] 129.27.9.62:161
.1.3.6.1.2.1.43.18.1.1.7.1.1
iso.3.6.1.2.1.43.18.1.1.7.1.1 = INTEGER: 1104
Processing oid 1 (line 1)
  oidname: iso.3.6.1.2.1.43.18.1.1.7.1.1
  response:  = INTEGER: 1104
SNMP OK - 1104 | iso.3.6.1.2.1.43.18.1.1.7.1.1=1104 
/usr/bin/snmpget -t 1 -r 5 -m '' -v 2c [authpriv] 129.27.9.62:161
.1.3.6.1.2.1.43.18.1.1.7.1.1
iso.3.6.1.2.1.43.18.1.1.7.1.1 = INTEGER: 1104
Processing oid 1 (line 1)
  oidname: iso.3.6.1.2.1.43.18.1.1.7.1.1
  response:  = INTEGER: 1104
SNMP OK - 1104 | iso.3.6.1.2.1.43.18.1.1.7.1.1=1104 
/usr/bin/snmpget -t 1 -r 5 -m '' -v 2c [authpriv] 129.27.9.62:161
.1.3.6.1.2.1.43.18.1.1.7.1.1
iso.3.6.1.2.1.43.18.1.1.7.1.1 = INTEGER: 1104
Processing oid 1 (line 1)
  oidname: iso.3.6.1.2.1.43.18.1.1.7.1.1
  response:  = INTEGER: 1104
SNMP OK - 1104 | iso.3.6.1.2.1.43.18.1.1.7.1.1=1104 

Thank you!

Regards, Simon


----------------------------------------------------------------------

Comment By: Holger Weiss (hweiss)
Date: 2013-08-06 01:45

Message:
Thanks for your report.  Could you check whether you can reproduce the bug
after running

$ git revert --no-edit bd782990

in your clone of the Git repository?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=397597&aid=3614879&group_id=29880

------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and 
AppDynamics. Performance Central is your source for news, insights, 
analysis and resources for efficient Application Performance Management. 
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________________
Nagios Plugin Development Mailing List Nagiosplug-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel
::: Please include plugins version (-v) and OS when reporting any issue. 
::: Messages without supporting info will risk being sent to /dev/null