[nagios-plugins] check_oracle: --tns bad string matching (#1191)
waja <notifications-9UaJU3cA/F/[email protected]> Tue, 01 Oct 2013 06:03:22 -0700
| Newsgroups | gmane.network.nagios.plugins.devel |
|---|---|
| Message-ID | <nagios-plugins/nagios-plugins/pull/[email protected]> |
--===============0056732940180288312==
Content-Type: multipart/alternative;
boundary="--==_mimepart_524ac81a48310_5e6ad3bd50354633";
charset=UTF-8
Content-Transfer-Encoding: 7bit
----==_mimepart_524ac81a48310_5e6ad3bd50354633
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
check_oracle in the 1.4.15 release doesn't correctly parse the output gotten
from at least Oracle 11 (with german locales). I guess it's probably more.
Also it completely needlessly uses sed where basic bash string parsing actually
does more than suffice (and does not run into possible problems with locales
like sed ;)).
--
Just turning attached patch of github issue #1015 into a push request.
(Closes #1015)
You can merge this Pull Request by running:
git pull https://github.com/waja/nagios-plugins github1015
Or you can view, comment on it, or merge it online at:
https://github.com/nagios-plugins/nagios-plugins/pull/1191
-- Commit Summary --
* check_oracle: --tns bad string matching
-- File Changes --
M THANKS.in (1)
M plugins-scripts/check_oracle.sh (2)
-- Patch Links --
https://github.com/nagios-plugins/nagios-plugins/pull/1191.patch
https://github.com/nagios-plugins/nagios-plugins/pull/1191.diff
----==_mimepart_524ac81a48310_5e6ad3bd50354633
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
<p>check_oracle in the 1.4.15 release doesn't correctly parse the output gotten<br>
from at least Oracle 11 (with german locales). I guess it's probably more.<br>
Also it completely needlessly uses sed where basic bash string parsing actually<br>
does more than suffice (and does not run into possible problems with locales</p>
<h2>like sed ;)).</h2>
<p>Just turning attached patch of github issue <a href="https://github.com/nagios-plugins/nagios-plugins/issues/1015" class="issue-link" title="check_oracle --tns bad string matching [sf#3389177]">#1015</a> into a push request.<br>
(Closes <a href="https://github.com/nagios-plugins/nagios-plugins/issues/1015" class="issue-link" title="check_oracle --tns bad string matching [sf#3389177]">#1015</a>)</p>
<hr>
<h4>You can merge this Pull Request by running</h4>
<pre> git pull https://github.com/waja/nagios-plugins github1015</pre>
<p>Or view, comment on, or merge it at:</p>
<p> <a href='https://github.com/nagios-plugins/nagios-plugins/pull/1191'>https://github.com/nagios-plugins/nagios-plugins/pull/1191</a></p>
<h4>Commit Summary</h4>
<ul>
<li>check_oracle: --tns bad string matching</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/nagios-plugins/nagios-plugins/pull/1191/files#diff-0">THANKS.in</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/nagios-plugins/nagios-plugins/pull/1191/files#diff-1">plugins-scripts/check_oracle.sh</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/nagios-plugins/nagios-plugins/pull/1191.patch'>https://github.com/nagios-plugins/nagios-plugins/pull/1191.patch</a></li>
<li><a href='https://github.com/nagios-plugins/nagios-plugins/pull/1191.diff'>https://github.com/nagios-plugins/nagios-plugins/pull/1191.diff</a></li>
</ul>
----==_mimepart_524ac81a48310_5e6ad3bd50354633--
--===============0056732940180288312==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk
--===============0056732940180288312==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________________
Nagios Plugin Development Mailing List Nagiosplug-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel
::: Please include plugins version (-v) and OS when reporting any issue.
::: Messages without supporting info will risk being sent to /dev/null
--===============0056732940180288312==--