[nagios-plugins] check_ntp_peers peer count check is inversed (#1204)

--===============1983500001937039395==
Content-Type: multipart/alternative;
	boundary="--==_mimepart_526043108d809_e416545d44229630";
	charset=UTF-8
Content-Transfer-Encoding: 7bit

----==_mimepart_526043108d809_e416545d44229630
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

It seems that the peer check in check_ntp_peers is backwards from what is useful in a production environment.

I have a server with 5 peers, and running the check with the following arguments yields the following results:

<table>
<tr><th>Arguments</th><th>Results</th>
<tr><td>-n 4</td><td>NTP CRITICAL</d></tr>
<tr><td>-n 5</td><td>NTP OK</d></tr>
<tr><td>-n 6</td><td>NTP OK</d></tr>
</table>

That seems backwards from what I would expect. Ideally the logic should be reversed. I don't care if I have "more than" 5 peers. I care if I have less. Looking at the source seems to confirm that the peer count metrics are all handled exactly the same as the jitter and offset, both of which logically work with a greater than concept.

---
Reply to this email directly or view it on GitHub:
https://github.com/nagios-plugins/nagios-plugins/issues/1204
----==_mimepart_526043108d809_e416545d44229630
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>It seems that the peer check in check_ntp_peers is backwards from what is useful in a production environment.</p>

<p>I have a server with 5 peers, and running the check with the following arguments yields the following results:</p>

<table>
<tr>
<th>Arguments</th>
<th>Results</th>
</tr>
<tr>
<td>-n 4</td>
<td>NTP CRITICAL</td>
</tr>
<tr>
<td>-n 5</td>
<td>NTP OK</td>
</tr>
<tr>
<td>-n 6</td>
<td>NTP OK</td>
</tr>
</table><p>That seems backwards from what I would expect. Ideally the logic should be reversed. I don't care if I have "more than" 5 peers. I care if I have less. Looking at the source seems to confirm that the peer count metrics are all handled exactly the same as the jitter and offset, both of which logically work with a greater than concept.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href='https://github.com/nagios-plugins/nagios-plugins/issues/1204'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/_EHT0K2RMtzboqJPrl-P-OQj2eHdmJlOSEZ0c7oXP9Yr4drw_FxbkG-UYpxTcmYz.gif' height='1' width='1'></p>
----==_mimepart_526043108d809_e416545d44229630--


--===============1983500001937039395==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
--===============1983500001937039395==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________________
Nagios Plugin Development Mailing List Nagiosplug-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel
::: Please include plugins version (-v) and OS when reporting any issue. 
::: Messages without supporting info will risk being sent to /dev/null
--===============1983500001937039395==--