Re: [nagios-plugins] check_procs: add option to ignore plugin parent process (#1205)
Holger Weiß <notifications-9UaJU3cA/F/[email protected]> Sun, 27 Oct 2013 14:03:46 -0700
| Newsgroups | gmane.network.nagios.plugins.devel |
|---|---|
| Message-ID | <nagios-plugins/nagios-plugins/pull/1205/[email protected]> |
--===============4055898028032643687== Content-Type: multipart/alternative; boundary="--==_mimepart_526d7fb285913_5af876bd30132884"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_526d7fb285913_5af876bd30132884 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks for this very nice commit. Usually, I'm really conservative with regards to backward compatibility, but in this case, I'd consider your change a de facto bug fix. So, I think I wouldn't make the new behaviour optional, but rather add a WARNING to the `NEWS` file and have users revert their workarounds. --- Reply to this email directly or view it on GitHub: https://github.com/nagios-plugins/nagios-plugins/pull/1205#issuecomment-27179270 ----==_mimepart_526d7fb285913_5af876bd30132884 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <p>Thanks for this very nice commit.</p> <p>Usually, I'm really conservative with regards to backward compatibility, but in this case, I'd consider your change a de facto bug fix. So, I think I wouldn't make the new behaviour optional, but rather add a WARNING to the <code>NEWS</code> file and have users revert their workarounds.</p> <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href='https://github.com/nagios-plugins/nagios-plugins/pull/1205#issuecomment-27179270'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/_EHT0K2RMtzboqJPrl-P-N4vlIje33_U1R5qfU20bVppuZeyosLahTjs-R9uCO9p.gif' height='1' width='1'></p> ----==_mimepart_526d7fb285913_5af876bd30132884-- --===============4055898028032643687== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk --===============4055898028032643687== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________________ Nagios Plugin Development Mailing List Nagiosplug-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Unsubscribe at https://lists.sourceforge.net/lists/listinfo/nagiosplug-devel ::: Please include plugins version (-v) and OS when reporting any issue. ::: Messages without supporting info will risk being sent to /dev/null --===============4055898028032643687==--