Re: Fix patch for SF bug 2833

On 03/21/18 19:43, Eric S. Raymond wrote:
>>From 54e79ba66327bdb54f97f457d76531f657ec546d Mon Sep 17 00:00:00 2001
> From: "Eric S. Raymond" <[email protected]>
> Date: Wed, 21 Mar 2018 22:22:29 -0400
> Subject: [PATCH] include/net-snmp/agent/{snmp_vars.h,var_struct.h}: address SF
>   bug 2833.

Are you familiar with "git send-email"? Using that command may be more 
convenient that copy/pasting patches into an e-mail.

> diff --git a/include/net-snmp/agent/snmp_vars.h b/include/net-snmp/agent/snmp_vars.h
> index bd27eeb..b2f2f8f 100644
> --- a/include/net-snmp/agent/snmp_vars.h
> +++ b/include/net-snmp/agent/snmp_vars.h
> @@ -101,7 +101,7 @@ PERFORMANCE OF THIS SOFTWARE.
>   #define INST	0xFFFFFFFF      /* used to fill out the instance field of the variables table */
>   
>       struct variable {
> -        u_char          magic;  /* passed to function as a hint */
> +        u_short         magic;  /* passed to function as a hint */
>           char            type;   /* type of variable */
>           /*
>            * See important comment in snmp_vars.c relating to acl

This patch changes a data structure in a public header file and hence 
breaks the ABI. This is something we could do for Net-SNMP 5.8 since 
there has not yet been any 5.8 release but it's something we can't do 
for older Net-SNMP versions.

Bart.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot