[PATCH 00/15] Clean up Net-SNMP public header files

Hello,

Since Net-SNMP version 5.8 will be released soon and since no prior version
has been released from the v5.8 (master) branch yet this is a good time to
review the public header files and verify whether any potentially backwards
incompatible changes should be made. The patches in this series are what I
came up with myself. As usual, feedback is welcome.

Bart.

Bart Van Assche (15):
  Cygwin64: Fix winExtDLL build
  <net-snmp/library/tools.h>: Add a missing #include directive
  <net-snmp/library/snmp_api.h>: Add missing #include directives
  <net-snmp/session_api.h>: Add a missing forward declaration
  <net-snmp/agent/snmp_agent.h>: Add a missing #include directive
  win32/config.h.borland: Remove this header file
  include/net-snmp/system/*: Remove unused preprocessor symbols
  Darwin: Move SNMP_CFRelease() definition
  libsnmp: Fix the recursive dependency between <net-snmp/types.h> and
    <net-snmp/library/types.h>
  libsnmp: Remove ONE_SEC definition
  libsnmp: Define MAX_OID_LEN once instead of three times
  <net-snmp/definitions.h>: Remove this header file
  <net-snmp/library/libsnmp.h>: Remove this header file
  <net-snmp/library/snmp_api.h>: Stop including from <net-snmp/types.h>
  <net-snmp/types.h>: Reduce the number of #include directives further

 agent/Makefile.depend                           |  84 ---
 agent/helpers/Makefile.depend                   |  54 --
 agent/mibgroup/Makefile.depend                  | 334 ----------
 agent/mibgroup/agentx/agentx_config.c           |   2 +-
 agent/mibgroup/agentx/client.c                  |   6 +-
 agent/mibgroup/host/data_access/swinst_darwin.c |   3 +
 apps/Makefile.depend                            |  62 --
 apps/snmpnetstat/Makefile.depend                |  16 -
 include/net-snmp/agent/snmp_agent.h             |   1 +
 include/net-snmp/definitions.h                  |  32 -
 include/net-snmp/library/asn1.h                 |   2 -
 include/net-snmp/library/libsnmp.h              | 174 ------
 include/net-snmp/library/oid.h                  |  11 +
 include/net-snmp/library/snmp_api.h             |  18 +-
 include/net-snmp/library/snmp_transport.h       |   2 +
 include/net-snmp/library/tools.h                |   5 +-
 include/net-snmp/library/types.h                |  70 ---
 include/net-snmp/net-snmp-includes.h            |   7 +-
 include/net-snmp/session_api.h                  |   1 +
 include/net-snmp/system/aix.h                   |   2 +-
 include/net-snmp/system/cygwin.h                |   4 -
 include/net-snmp/system/darwin10.h              |   7 -
 include/net-snmp/system/darwin11.h              |   7 -
 include/net-snmp/system/darwin12.h              |   7 -
 include/net-snmp/system/darwin13.h              |   7 -
 include/net-snmp/system/darwin14.h              |   7 -
 include/net-snmp/system/darwin7.h               |   3 -
 include/net-snmp/system/darwin9.h               |   7 -
 include/net-snmp/system/dragonfly.h             |   4 -
 include/net-snmp/system/dynix.h                 |   3 -
 include/net-snmp/system/freebsd.h               |   3 -
 include/net-snmp/system/freebsd2.h              |   1 -
 include/net-snmp/system/freebsd3.h              |   2 -
 include/net-snmp/system/freebsd4.h              |   4 -
 include/net-snmp/system/generic.h               |  14 -
 include/net-snmp/system/hpux.h                  |  10 -
 include/net-snmp/system/linux.h                 |   2 -
 include/net-snmp/system/mingw32.h               |   3 -
 include/net-snmp/system/mips.h                  |   2 -
 include/net-snmp/system/netbsd.h                |   5 -
 include/net-snmp/system/nto-qnx6.h              |   3 -
 include/net-snmp/system/openbsd.h               |   1 -
 include/net-snmp/system/openbsd5.h              |   2 -
 include/net-snmp/system/solaris.h               |   3 -
 include/net-snmp/types.h                        |  76 ++-
 include/net-snmp/varbind_api.h                  |   1 +
 snmplib/Makefile.depend                         | 150 -----
 snmplib/Makefile.in                             |   1 -
 snmplib/cert_util.c                             |   1 +
 snmplib/snmp-tc.c                               |   1 +
 snmplib/snmp.c                                  |   1 +
 snmplib/snmp_api.c                              |   4 +-
 snmplib/snmp_client.c                           |   3 +
 snmplib/transports/snmpAAL5PVCDomain.c          |   1 +
 snmplib/transports/snmpDTLSUDPDomain.c          |   1 +
 snmplib/transports/snmpIPv4BaseDomain.c         |   1 +
 snmplib/transports/snmpIPv6BaseDomain.c         |   1 +
 snmplib/transports/snmpSSHDomain.c              |   1 +
 snmplib/transports/snmpSTDDomain.c              |   2 +-
 snmplib/transports/snmpTCPDomain.c              |   1 +
 snmplib/transports/snmpTCPIPv6Domain.c          |   1 +
 snmplib/transports/snmpTLSBaseDomain.c          |   2 +
 snmplib/transports/snmpTLSTCPDomain.c           |   1 +
 snmplib/transports/snmpUDPDomain.c              |   1 +
 snmplib/transports/snmpUDPIPv6Domain.c          |   1 +
 snmplib/transports/snmpUnixDomain.c             |   2 +
 snmplib/vacm.c                                  |   2 +
 win32/config.h.borland                          | 772 ------------------------
 win32/dist/installer/net-snmp.nsi               |   2 -
 69 files changed, 128 insertions(+), 1899 deletions(-)
 delete mode 100644 include/net-snmp/definitions.h
 delete mode 100644 include/net-snmp/library/libsnmp.h
 delete mode 100644 include/net-snmp/library/types.h
 delete mode 100644 win32/config.h.borland

-- 
2.16.3


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot