Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

Bart Van Assche <[email protected]> Thu, 13 Aug 2020 19:54:58 -0700

Newsgroups	gmane.network.net-snmp.devel
Message-ID	<[email protected]>

On 2020-08-13 18:16, Magnus Fromreide wrote:
> Now I have finally gotten around to look more thoroughly into this and found
> that your patch is basically good.
> 
> For the agent/snmpd.c part I would like to change my vote to +1.

Thanks!

> For the pass_persist part you are keeping the fclose of fOut but the rest of
> the code is writing to fdOut so I would like to add the attached patch on top
> of yours. It kills of fOut and fdIn so that there is only one reference to
> the file descriptor. 
The attached patch looks good to me.

Bart.