Re: Newsx and inn 2.4.0?

Le Mar 20 mai 03 =E0 12:38:32 +0200, Egil Kvaleberg <[email protected]>
 =E9crivait=A0:
> > Actually, to correct this, we should include <sys/param.h> together w=
ith
> > sys/mount.h, because NGROUPS is defined there. In src/freespc.c, they
> > are included together.
>=20
> Exactly.=20
>=20
> So this is in fact a bug in configure/autoconf and not newsx. Perhaps
> you would care to report the problem to [email protected] (since you
> have a system on which this appears to be a problem).

No problem - we have old autoconf / automake in the FreeBSD ports tree,
but someone is working about that.

> > 2) Some warnings remain. They are not important, but if you care abou=
t
> > that, I list them:
>=20
> I do care about warnings, and strive to get rid of them.
>=20
> I've gone through your list, and to me it appears that getting rid of
> the majority of these warnings in a proper manner requires some
> knowledge about your systems include files that I don't have. They do
> not appear in my environment. Which means I need input from you.

They were easy to fix: I've uploaded my patches at
<http://pompo.net/ports/newsx/>.

patch-lib_getopt.c fixes "getopt.c:561: warning: suggest explicit braces
to avoid ambiguous `else'".

The other fix these warnings:

putarticle.c: In function `sniff_article':
putarticle.c:293: warning: initialization discards qualifiers from pointe=
r target type
putarticle.c: In function `write_article':
putarticle.c:340: warning: initialization discards qualifiers from pointe=
r target type
putarticle.c: In function `kill_article':
putarticle.c:671: warning: passing arg 2 of `bounce_msg' discards qualifi=
ers from pointer target type

telnet.c: In function `str_telcmd':
telnet.c:134: warning: return discards qualifiers from pointer target typ=
e
telnet.c: In function `str_telopt':
telnet.c:150: warning: return discards qualifiers from pointer target typ=
e

sim.c: In function `SIMfreearticle':
sim.c:174: warning: passing arg 1 of `free' discards qualifiers from poin=
ter target type

The problem was because article->data is defined as const in storage.h /
ARTHANDLE; idem for TELCMD and TELOPT, and the qualifier is lost...

It don't seems to be FreeBSD specific, but if it were, it is possible to
use #if defined(__FreeBSD__)

> That said, it seems none look like they are "dangerous"=20

No, they are not; I don't even know why gcc warn about that.
Nevertheless, some people fear warnings, and it's better to fix them.

> > > I presume it is probably a good idea to move the newsx package to
> > > sourceforge. Any thoughts?
> >=20
> > The advantage would be a CVS; why not?
>=20
> For my own use I have CVS already, but I have not made it available for
> the public. The idea wrt. sourceforge (or similar) was to try to share
> responsibility for this package - as you have noticed I really do not
> have very much resources available for this right now, and it will not
> improve in the next year, for sure.

OK.
--=20
Th. Thomas.

-----------------------------------------------------------------------
This message has been sent to you because you are subcribed to the mailin=
g
list [email protected]. To remove yourself from this lists, send an emai=
l to
[email protected] containing "unsubscribe newsx <your_email_address>=
"
in the message body.