Re: NoCatSplash sync patch

I've applied this patch to the SourceForge CVS. Thanks very much for
the patch, Jeff.

Expect a pre3 release once I sort out this block-on-read bug that
people have reported. It looks like http_request_read() is going into
an infinite loop. Not sure why yet, but at least I have something to
go on.

SDE

* On 25-Apr-2005 at  4:31PM PDT, J. Kyllo said:
> Well, I see that the list filters attachments - which is good, I just
> didn't think of it.  The patch is available at the following (although I
> need to add some comments to it):
> 
> http://jkyllo.echospiral.com/download/code/nocat-splash_0.93pre2-fseek.patch
> 
> Cheers,
> Jeff
> 
> > Hello NoCat list.  I have been using NoCatAuth for a while now and was
> > looking into NoCatSplash.  I run debian so I was looking to build a .deb
> > for NoCatSplash.  While trying to use the sample rc/init script in the
> > 0.93pre2 tarball, I found that splashd does not sync the pid file.  The
> > result of this is that the init script is not able to kill the process.
> >
> > I did some poking around and saw that the pidfile doesn't get closed until
> > splashd is exiting (and the next action is to unlink it).  Attached is a
> > one line patch that uses a call to fseek to effectly sync the file.  I
> > used fseek to keep with the use of FILE* as opposed to fd.
> >
> > Any thoughts on this?  On one hand, I would think that the pidfile should
> > really just be closed after it is written.  But I can also understand that
> > it should stay open with the running daemon.  Either way, this patch
> > sync's the file and lets the init script work correctly.
> >
> > Thanks,
> > Jeff K._______________________________________________
> > NoCat mailing list
> > [email protected]
> > http://lists.nocat.net/mailman/listinfo/nocat
> >
> 
> 
> 
> _______________________________________________
> NoCat mailing list
> [email protected]
> http://lists.nocat.net/mailman/listinfo/nocat