[OpenNMS/opennms] ce265a: NMS-20100: second review pass on the Notifications...

joseanesONMS via opennms-cvs <[email protected]> Fri, 31 Jul 2026 12:34:00 -0700
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20100-notifications-page/[email protected]>
  Branch: refs/heads/jira/NMS-20100-notifications-page
  Home:   https://github.com/OpenNMS/opennms
  Commit: ce265a89f3ec2732591a06610cdec4fa3aed587f
      https://github.com/OpenNMS/opennms/commit/ce265a89f3ec2732591a06610cdec4fa3aed587f
  Author: Jose Anes <[email protected]>
  Date:   2026-07-31 (Fri, 31 Jul 2026)

  Changed paths:
    A opennms-webapp-rest/127.0.0.1.tm0.epoch
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    A opennms-webapp-rest/tmlog0.log
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    M ui/src/components/AdminNotifications/NoticesTable.vue
    R ui/src/containers/AdminNotifications.vue
    A ui/src/containers/Notifications.vue
    M ui/src/main/router/index.ts
    M ui/src/stores/noticesStore.ts
    A ui/tests/composables/useBrowserNotifications.test.ts
    M ui/tests/stores/noticesStore.test.ts

  Log Message:
  -----------
  NMS-20100: second review pass on the Notifications page

The configuration dialog declares all four tabs with placeholder panels
and per-tab loaders that latch only on success: the sibling tab PRs each
replace one placeholder instead of restructuring the dialog, the tab
order is deliberate, and a failed load retries on the next visit.
User-scoped notice queries refuse to run without a user id instead of
silently widening to everyone's notices, and the ack rewind clamps to
the last valid page. The status event carries remoteHost and remoteAddr
like the legacy servlet, dead code is gone from the REST service, the
container is Notifications.vue since the page is not admin-gated,
OnmsIconButton uses its variant prop, the IT restores opennms.home, and
the browser-notification composable gets tests.



To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs