[OpenNMS/opennms] fdf242: NMS-20118: Event Notifications tab

joseanesONMS via opennms-cvs <[email protected]> Mon, 03 Aug 2026 07:59:17 -0700
Newsgroups gmane.network.opennms.cvs
Message-ID <OpenNMS/opennms/push/refs/heads/jira/NMS-20118-event-notifications/[email protected]>
  Branch: refs/heads/jira/NMS-20118-event-notifications
  Home:   https://github.com/OpenNMS/opennms
  Commit: fdf242979f91074249bfb3c73cd4a9cf6a536fc4
      https://github.com/OpenNMS/opennms/commit/fdf242979f91074249bfb3c73cd4a9cf6a536fc4
  Author: Jose Anes <[email protected]>
  Date:   2026-08-03 (Mon, 03 Aug 2026)

  Changed paths:
    M opennms-webapp-rest/src/main/java/org/opennms/web/rest/v1/NotificationConfigRestService.java
    M opennms-webapp-rest/src/test/java/org/opennms/web/rest/v1/NotificationConfigRestServiceIT.java
    M ui/src/components/AdminNotifications/ConfigureNotificationsDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationEditorDialog.vue
    A ui/src/components/AdminNotifications/EventNotificationsTable.vue
    M ui/src/services/index.ts
    M ui/src/services/notificationConfigService.ts
    M ui/src/stores/notificationConfigStore.ts
    M ui/src/types/notificationConfig.ts
    M ui/tests/stores/notificationConfigStore.test.ts

  Log Message:
  -----------
  NMS-20118: Event Notifications tab

Replaces the event-notifications placeholder with the tab content: the
notification list with per-notification on/off toggles, an add/edit
dialog with a searchable UEI picker fed by the event configuration, and
delete with confirmation. The /rest/notification-config
event-notifications endpoints wrap the notifications.xml factory the
legacy wizard uses.

Deleting the last event notification is rejected (notifications.xsd
requires at least one, and the schema-validated save would diverge
memory from the file until a restart), and validation covers every field
whose asserting setter could kill the factory's in-place update chain,
including status and parameter names/values.


  Commit: e62bc00c0ade3a4597373a2ec059c1f5762e89f2
      https://github.com/OpenNMS/opennms/commit/e62bc00c0ade3a4597373a2ec059c1f5762e89f2
  Author: Jose Anes <[email protected]>
  Date:   2026-08-03 (Mon, 03 Aug 2026)

  Changed paths:
    M ui/src/components/AdminNotifications/EventNotificationsTable.vue
    M ui/src/services/notificationConfigService.ts

  Log Message:
  -----------
  NMS-20118: surface the delete guard and disable deleting the last notification

Deleting an event notification now surfaces the server's reason instead of a
generic failure, so the "last event notification cannot be deleted" guard reads
as an explanation rather than an unexplained error. The Delete button is disabled
when only one notification remains, with a title pointing the user at turning it
off instead.


Compare: https://github.com/OpenNMS/opennms/compare/27d3ec978fd8...e62bc00c0ade

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs