[OpenNMS/opennms] da227f: NMS-20114: Remove the Asterisk notification strate...

  Branch: refs/heads/mm/NMS-20114-smoke
  Home:   https://github.com/OpenNMS/opennms
  Commit: da227f4e434e72e3b0bf88fa1ec6ca1f49405487
      https://github.com/OpenNMS/opennms/commit/da227f4e434e72e3b0bf88fa1ec6ca1f49405487
  Author: Marshall Massengill <[email protected]>
  Date:   2026-08-03 (Mon, 03 Aug 2026)

  Changed paths:
    M core/lib/src/main/java/org/opennms/core/utils/ConfigFileConstants.java
    R dependencies/asterisk/pom.xml
    M dependencies/pom.xml
    M docs/modules/operation/pages/deep-dive/notifications/commands.adoc
    M docs/modules/operation/pages/deep-dive/notifications/introduction.adoc
    M docs/modules/reference/pages/configuration/system-properties.adoc
    M docs/modules/reference/pages/daemons/introduction.adoc
    M integration-tests/config/pom.xml
    R opennms-asterisk/pom.xml
    R opennms-asterisk/src/license/THIRD-PARTY.properties
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/agi/AsteriskGateway.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/agi/jmx/AsteriskGateway.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/agi/jmx/AsteriskGatewayMBean.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/agi/scripts/BaseOnmsAgiScript.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/agi/scripts/LouieLouieLyricsAgiScript.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/agi/scripts/ReadNoticeDetailsAgiScript.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/monitor/AsteriskSIPPeerMonitor.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/utils/AsteriskConfig.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/utils/AsteriskOriginator.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/utils/AsteriskOriginatorException.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/asterisk/utils/AsteriskUtils.java
    R opennms-asterisk/src/main/java/org/opennms/netmgt/notifd/asterisk/AsteriskOriginateNotificationStrategy.java
    R opennms-asterisk/src/main/resources/META-INF/opennms/applicationContext-asteriskGateway.xml
    R opennms-asterisk/src/main/resources/META-INF/services/org.opennms.netmgt.poller.ServiceMonitor
    R opennms-asterisk/src/main/resources/beanRefContext.xml
    M opennms-base-assembly/pom.xml
    R opennms-base-assembly/src/main/filtered/etc/asterisk-configuration.properties
    M opennms-base-assembly/src/main/filtered/etc/examples/notificationCommands.xml
    M opennms-base-assembly/src/main/filtered/etc/log4j2.xml
    M opennms-base-assembly/src/main/filtered/etc/notificationCommands.xml
    M opennms-base-assembly/src/main/filtered/etc/opennms.properties
    M opennms-config-tester/src/main/resources/META-INF/opennms/applicationContext-configTester.xml
    M opennms-config-tester/src/test/java/org/opennms/netmgt/config/tester/ConfigTesterTest.java
    M pom.xml

  Log Message:
  -----------
  NMS-20114: Remove the Asterisk notification strategy and AGI gateway

AsteriskOriginateNotificationStrategy originated a call over the Asterisk
Manager Interface and passed the notice details as channel variables; the
bundled FastAGI server read them back to the answering party using canned
Asterisk sound files. That gateway is named in no shipped
service-configuration.xml, so nothing started it, and asterisk-java
1.0.0-final dates to 2009.

AsteriskSIPPeerMonitor goes as well. Its SipShowPeerAction is the AMI form
of "sip show peer", which is chan_sip only; Asterisk deprecated that channel
driver in 17 and removed it in 21, so the monitor reports Down regardless of
peer state on current versions.

SNMP data collection for Asterisk servers is untouched:
etc/datacollection/asterisk.xml and asterisk-graph.properties remain, keyed
on sysoid .1.3.6.1.4.1.22736.1.

integration-tests/config reached opennms-services transitively through
opennms-asterisk, which is how ServiceConfigurationPublicConstructorIT
resolved the daemon classes named in service-configuration.xml. It now
declares that dependency directly.

ConfigFileConstants id 74 is retired rather than renumbered, matching the
gaps already in that table.


  Commit: 03354f371e944e8db85b65e013034201dbb1a07a
      https://github.com/OpenNMS/opennms/commit/03354f371e944e8db85b65e013034201dbb1a07a
  Author: Marshall Massengill <[email protected]>
  Date:   2026-08-03 (Mon, 03 Aug 2026)

  Changed paths:
    M core/lib/src/main/java/org/opennms/core/utils/ConfigFileConstants.java
    M integration-tests/config/src/test/java/org/opennms/netmgt/config/WillItUnmarshalIT.java
    R opennms-base-assembly/src/main/filtered/etc/ami-config.xml
    M opennms-config-model/pom.xml
    R opennms-config-model/src/main/java/org/opennms/netmgt/config/ami/AmiAgentConfig.java
    R opennms-config-model/src/main/java/org/opennms/netmgt/config/ami/AmiConfig.java
    R opennms-config-model/src/main/java/org/opennms/netmgt/config/ami/Definition.java
    R opennms-config-model/src/main/java/org/opennms/netmgt/config/ami/Range.java
    R opennms-config-model/src/main/java/org/opennms/netmgt/config/ami/package-info.java
    R opennms-config-model/src/main/resources/xsds/ami-config.xsd
    R opennms-config-model/src/test/java/org/opennms/netmgt/config/ami/AmiConfigTest.java
    M opennms-config-tester/src/main/resources/META-INF/opennms/applicationContext-configTester.xml
    M opennms-config-tester/src/test/java/org/opennms/netmgt/config/tester/ConfigTesterTest.java
    R opennms-config/src/main/java/org/opennms/netmgt/config/AmiPeerFactory.java
    M opennms-config/src/main/resources/META-INF/opennms/component-dao.xml
    R opennms-config/src/test/java/org/opennms/netmgt/config/AmiPeerFactoryTest.java
    R opennms-config/src/test/resources/etc/ami-config.xml
    M ui/tests/fileEditor.test.ts

  Log Message:
  -----------
  NMS-20114: Remove the orphaned AMI peer configuration

AmiPeerFactory and ami-config.xml existed only to hand AMI credentials to
AsteriskOriginator and AsteriskSIPPeerMonitor. Both are gone, leaving no
consumers, so the factory, the org.opennms.netmgt.config.ami model, the XSD,
the shipped ami-config.xml, and the config-tester and WillItUnmarshal
coverage for it are removed.

ConfigFileConstants id 75 is retired rather than renumbered, matching the
gaps already in that table.

The fileEditor unit test used ami-config.xml as arbitrary sample data for
its root-level-file case; it now names categories.xml instead.


Compare: https://github.com/OpenNMS/opennms/compare/da227f4e434e%5E...03354f371e94

To unsubscribe from these emails, change your notification settings at https://github.com/OpenNMS/opennms/settings/notifications


_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/wiki/index.php?page=MailingListFaq
opennms-cvs mailing list

To *unsubscribe* or change your subscription options, see the bottom of this page:
https://lists.sourceforge.net/lists/listinfo/opennms-cvs